Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(249)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1698523003: Subzero: Add x86-64 to the bots. (Closed)

Created:
4 years, 10 months ago by Jim Stichnoth
Modified:
4 years, 10 months ago
CC:
native-client-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/native_client/src/native_client.git@master
Target Ref:
refs/heads/master
Project:
nacl
Visibility:
Public.

Description

Subzero: Add x86-64 to the bots. This mirrors the changes in the following x86-32 CLs: https://codereview.chromium.org/1022143004/ - "pnacl-translate --use-sz" https://codereview.chromium.org/1026243002/ - add sz configs to test scripts https://codereview.chromium.org/1047543002/ - enable sz on specbots https://codereview.chromium.org/1045573002/ - enable sz on LLVM testsuite bot https://codereview.chromium.org/1037183002/ - enable sz on scons test bot https://codereview.chromium.org/1046323005/ - add sz sandboxed translator spec tests Prerequisite CLs: https://codereview.chromium.org/1695893002/ - pnacl-translate -arch x86-64 --use-sz https://codereview.chromium.org/1692253005/ - pnacl_targetlibs.py for Subzero x86-64 https://codereview.chromium.org/1697873003/ - build/archive x86-64 pnacl-sz SB translator For now, Subzero x86-64 sandboxed translator tests (including spec2k) can't be enabled because Subzero's BrowserCompileServer::getParsedFlags() forces sandboxed x86-32 output. It's also possible that the build scripts build pnacl-sz.nexe with only the x86-32 target enabled; more investigation is needed. BUG= https://bugs.chromium.org/p/nativeclient/issues/detail?id=4077 Committed: https://chromium.googlesource.com/native_client/src/native_client/+/7fa48428204209576a874cee560831620ca29847

Patch Set 1 #

Patch Set 2 : Revert pnacl-translate.py change #

Patch Set 3 : Disable Subzero x86-64 translator tests for now #

Unified diffs Side-by-side diffs Delta from patch set Stats (+86 lines, -8 lines) Patch
M buildbot/buildbot_pnacl.py View 2 chunks +2 lines, -2 lines 0 comments Download
M buildbot/buildbot_pnacl_toolchain_tests.sh View 1 2 1 chunk +1 line, -1 line 0 comments Download
M buildbot/buildbot_spec2k.sh View 1 2 2 chunks +15 lines, -4 lines 0 comments Download
M tests/spec2k/Makefile.common View 3 chunks +15 lines, -0 lines 0 comments Download
M tests/spec2k/run_all.sh View 3 chunks +24 lines, -0 lines 0 comments Download
M tools/toolchain_tester/toolchain_config.py View 1 chunk +28 lines, -0 lines 0 comments Download
M tools/toolchain_tester/torture_test.py View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 15 (11 generated)
Jim Stichnoth
4 years, 10 months ago (2016-02-15 14:09:59 UTC) #10
John
lgtm
4 years, 10 months ago (2016-02-15 17:29:29 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1698523003/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1698523003/40001
4 years, 10 months ago (2016-02-15 17:29:39 UTC) #13
commit-bot: I haz the power
4 years, 10 months ago (2016-02-15 17:30:49 UTC) #15
Message was sent while issue was closed. 
Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/native_client/src/native_client/+/7fa484282...

Powered by Google App Engine
This is Rietveld 408576698