Remove last bit of privacy violation for GrAtlasTextBlob

Remove last bit of privacy violation for GrAtlasTextBlob

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1698503002

Committed: https://skia.googlesource.com/skia/+/ddd22d86455d95941ea21253b210819c1d4a3863

[joshua.litt, 2016-02-12 17:59:04]

Description was changed from

==========
Remove last bit of privacy violation for GrAtlasTextBlob

BUG=skia:
==========

to

==========
Remove last bit of privacy violation for GrAtlasTextBlob

BUG=skia:
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

[joshualitt, 2016-02-12 18:07:13]

joshualitt@google.com changed reviewers:
+ bsalomon@google.com, joshualitt@google.com, jvanverth@google.com

[joshualitt, 2016-02-12 18:07:14]

this patch looks kind of intimidating but its almost entirely a code move.  The
only novel parts are the new additions to GrAtlasTextBatch

Effectively, this patch makes GrAtlasTextBlob responsible for regenerating
itself within batch, which seems a much cleaner design, and means no friending
is required

[jvanverth1, 2016-02-12 18:51:38]

lgtm + nits

https://codereview.chromium.org/1698503002/diff/40001/src/gpu/GrBatchAtlas.h
File src/gpu/GrBatchAtlas.h (right):

https://codereview.chromium.org/1698503002/diff/40001/src/gpu/GrBatchAtlas.h#...
src/gpu/GrBatchAtlas.h:16: #include "batches/GrDrawBatch.h"
Nit: By the style guide this should go before "GrTexture.h"

https://codereview.chromium.org/1698503002/diff/40001/src/gpu/text/GrAtlasTex...
File src/gpu/text/GrAtlasTextBlob_regenInBatch.cpp (right):

https://codereview.chromium.org/1698503002/diff/40001/src/gpu/text/GrAtlasTex...
src/gpu/text/GrAtlasTextBlob_regenInBatch.cpp:122: GrBatchFontCache* fontCache,
indenting

[joshualitt, 2016-02-16 13:17:02]

The CQ bit was checked by joshualitt@google.com

[joshualitt, 2016-02-16 13:17:02]

The patchset sent to the CQ was uploaded after l-g-t-m from jvanverth@google.com
Link to the patchset: https://codereview.chromium.org/1698503002/#ps60001
(title: "rebase + nits")

[commit-bot: I haz the power, 2016-02-16 13:17:04]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1698503002/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1698503002/60001

[commit-bot: I haz the power, 2016-02-16 14:47:54]

Description was changed from

==========
Remove last bit of privacy violation for GrAtlasTextBlob

BUG=skia:
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

to

==========
Remove last bit of privacy violation for GrAtlasTextBlob

BUG=skia:
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...

Committed:
https://skia.googlesource.com/skia/+/ddd22d86455d95941ea21253b210819c1d4a3863
==========

[commit-bot: I haz the power, 2016-02-16 14:47:55]

Committed patchset #4 (id:60001) as
https://skia.googlesource.com/skia/+/ddd22d86455d95941ea21253b210819c1d4a3863