src/compiler/ia32/instruction-selector-ia32.cc - Issue 1698483002: [arm][arm64] Improve CountTrailingZero implementation.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/compiler/ia32/instruction-selector-ia32.cc

Issue 1698483002: [arm][arm64] Improve CountTrailingZero implementation. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: comments addressed Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/compiler/ia32/instruction-selector-ia32.cc

diff --git a/src/compiler/ia32/instruction-selector-ia32.cc b/src/compiler/ia32/instruction-selector-ia32.cc

index 17577f70da5b8d8974f870fcd3c1ca545e67cc15..922f9a13eaeb61e148169519f6828e3487bd097e 100644

--- a/src/compiler/ia32/instruction-selector-ia32.cc

+++ b/src/compiler/ia32/instruction-selector-ia32.cc

@@ -592,6 +592,9 @@ void InstructionSelector::VisitWord32Ctz(Node* node) {

}

+void InstructionSelector::VisitWord32ReverseBits(Node* node) { UNREACHABLE(); }

void InstructionSelector::VisitWord32Popcnt(Node* node) {

IA32OperandGenerator g(this);

Emit(kIA32Popcnt, g.DefineAsRegister(node), g.Use(node->InputAt(0)));