src/compiler/arm64/code-generator-arm64.cc - Issue 1698483002: [arm][arm64] Improve CountTrailingZero implementation.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/compiler/arm64/code-generator-arm64.cc

Issue 1698483002: [arm][arm64] Improve CountTrailingZero implementation. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: comments addressed Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/compiler/arm64/code-generator-arm64.cc

diff --git a/src/compiler/arm64/code-generator-arm64.cc b/src/compiler/arm64/code-generator-arm64.cc

index 37d3161dc4870cf71137a2398251e0dce5834e52..7e1038330bec3f90f66884e30a7e7331a9e8bc16 100644

--- a/src/compiler/arm64/code-generator-arm64.cc

+++ b/src/compiler/arm64/code-generator-arm64.cc

@@ -976,6 +976,12 @@ void CodeGenerator::AssembleArchInstruction(Instruction* instr) {

case kArm64Clz32:

__ Clz(i.OutputRegister32(), i.InputRegister32(0));

break;

+ case kArm64Rbit:

+ __ Rbit(i.OutputRegister64(), i.InputRegister64(0));

+ break;

+ case kArm64Rbit32:

+ __ Rbit(i.OutputRegister32(), i.InputRegister32(0));

+ break;

case kArm64Cmp:

__ Cmp(i.InputOrZeroRegister64(0), i.InputOperand(1));

break;