src/compiler/arm/code-generator-arm.cc - Issue 1698483002: [arm][arm64] Improve CountTrailingZero implementation.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/compiler/arm/code-generator-arm.cc

Issue 1698483002: [arm][arm64] Improve CountTrailingZero implementation. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/compiler/arm/code-generator-arm.cc

diff --git a/src/compiler/arm/code-generator-arm.cc b/src/compiler/arm/code-generator-arm.cc

index ff1548272e11e10de896b02cf39de4f53bb6f4fc..21680b05eac645cf559795e91899deef5427a773 100644

--- a/src/compiler/arm/code-generator-arm.cc

+++ b/src/compiler/arm/code-generator-arm.cc

@@ -670,6 +670,12 @@ void CodeGenerator::AssembleArchInstruction(Instruction* instr) {

i.InputInt32(2));

DCHECK_EQ(LeaveCC, i.OutputSBit());

break;

+ case kArmRbit: {

+ CpuFeatureScope scope(masm(), ARMv7);

+ __ rbit(i.OutputRegister(), i.InputRegister(0));

+ DCHECK_EQ(LeaveCC, i.OutputSBit());

+ break;

+ }

case kArmClz:

__ clz(i.OutputRegister(), i.InputRegister(0));

DCHECK_EQ(LeaveCC, i.OutputSBit());