Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1247)

Side by Side Diff: test/cctest/test-debug.cc

Issue 1698473003: Clean up some random TODO(titzer)s and spelling mistakes. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « test/cctest/test-cpu-profiler.cc ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 7283 matching lines...) Expand 10 before | Expand all | Expand 10 after
7294 function_name->Equals(context, v8_str(isolate, "loop")).FromJust()); 7294 function_name->Equals(context, v8_str(isolate, "loop")).FromJust());
7295 // Get the name of the first argument in frame i. 7295 // Get the name of the first argument in frame i.
7296 result = frame_argument_name->Call(context, exec_state, argc, argv) 7296 result = frame_argument_name->Call(context, exec_state, argc, argv)
7297 .ToLocalChecked(); 7297 .ToLocalChecked();
7298 CHECK(result->IsString()); 7298 CHECK(result->IsString());
7299 v8::Local<v8::String> argument_name( 7299 v8::Local<v8::String> argument_name(
7300 result->ToString(context).ToLocalChecked()); 7300 result->ToString(context).ToLocalChecked());
7301 CHECK(argument_name->Equals(context, v8_str(isolate, "count")) 7301 CHECK(argument_name->Equals(context, v8_str(isolate, "count"))
7302 .FromJust()); 7302 .FromJust());
7303 // Get the value of the first argument in frame i. If the 7303 // Get the value of the first argument in frame i. If the
7304 // funtion is optimized the value will be undefined, otherwise 7304 // function is optimized the value will be undefined, otherwise
7305 // the value will be '1 - i'. 7305 // the value will be '1 - i'.
7306 // 7306 //
7307 // TODO(3141533): We should be able to get the real value for 7307 // TODO(3141533): We should be able to get the real value for
7308 // optimized frames. 7308 // optimized frames.
7309 result = frame_argument_value->Call(context, exec_state, argc, argv) 7309 result = frame_argument_value->Call(context, exec_state, argc, argv)
7310 .ToLocalChecked(); 7310 .ToLocalChecked();
7311 CHECK(result->IsUndefined() || 7311 CHECK(result->IsUndefined() ||
7312 (result->Int32Value(context).FromJust() == 1 - i)); 7312 (result->Int32Value(context).FromJust() == 1 - i));
7313 // Get the name of the first local variable. 7313 // Get the name of the first local variable.
7314 result = frame_local_name->Call(context, exec_state, argc, argv) 7314 result = frame_local_name->Call(context, exec_state, argc, argv)
(...skipping 734 matching lines...) Expand 10 before | Expand all | Expand 10 after
8049 CHECK_EQ(22, iterator->GetBreakLocation().position()); 8049 CHECK_EQ(22, iterator->GetBreakLocation().position());
8050 iterator->Next(); 8050 iterator->Next();
8051 CHECK(iterator->GetBreakLocation().IsReturn()); 8051 CHECK(iterator->GetBreakLocation().IsReturn());
8052 CHECK_EQ(50, iterator->GetBreakLocation().position()); 8052 CHECK_EQ(50, iterator->GetBreakLocation().position());
8053 iterator->Next(); 8053 iterator->Next();
8054 CHECK(iterator->Done()); 8054 CHECK(iterator->Done());
8055 delete iterator; 8055 delete iterator;
8056 8056
8057 DisableDebugger(isolate); 8057 DisableDebugger(isolate);
8058 } 8058 }
OLDNEW
« no previous file with comments | « test/cctest/test-cpu-profiler.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698