Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(398)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1698473003: Clean up some random TODO(titzer)s and spelling mistakes. (Closed)

Created:
4 years, 10 months ago by titzer
Modified:
4 years, 10 months ago
Reviewers:
Michael Starzinger
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Clean up some random TODO(titzer)s and spelling mistakes. R=mstarzinger@chromium.org BUG= Committed: https://crrev.com/54404c4731abd2bfc2d95453a4301f71b769a30f Cr-Commit-Position: refs/heads/master@{#33955}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -12 lines) Patch
M src/compiler/instruction-selector.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M src/compiler/representation-change.cc View 1 chunk +0 lines, -1 line 0 comments Download
M src/compiler/simplified-operator.cc View 1 chunk +0 lines, -1 line 0 comments Download
M src/deoptimizer.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M src/objects.h View 1 chunk +1 line, -1 line 0 comments Download
M test/cctest/compiler/codegen-tester.h View 2 chunks +0 lines, -2 lines 0 comments Download
M test/cctest/compiler/test-run-jscalls.cc View 1 chunk +0 lines, -1 line 0 comments Download
M test/cctest/test-cpu-profiler.cc View 1 chunk +1 line, -1 line 0 comments Download
M test/cctest/test-debug.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (2 generated)
titzer
4 years, 10 months ago (2016-02-12 15:17:27 UTC) #1
Michael Starzinger
LGTM.
4 years, 10 months ago (2016-02-12 16:55:44 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1698473003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1698473003/1
4 years, 10 months ago (2016-02-12 16:59:43 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 10 months ago (2016-02-12 17:30:06 UTC) #5
commit-bot: I haz the power
4 years, 10 months ago (2016-02-12 17:30:28 UTC) #7
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/54404c4731abd2bfc2d95453a4301f71b769a30f
Cr-Commit-Position: refs/heads/master@{#33955}

Powered by Google App Engine
This is Rietveld 408576698