Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(338)

Issue 1698463002: [runtime] Speed up Object::ToObject with JSReceiver argument. (Closed)

Created:
4 years, 10 months ago by Toon Verwaest
Modified:
4 years, 10 months ago
Reviewers:
Camillo Bruni
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[runtime] Speed up Object::ToObject with JSReceiver argument. This avoids having to read the context and call through from the inlined path in the JSReceiver case. BUG= Committed: https://crrev.com/2649611109db5f9d60b27c6b2b12e78e5ee9bb25 Cr-Commit-Position: refs/heads/master@{#33949}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M src/objects-inl.h View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
Toon Verwaest
ptal
4 years, 10 months ago (2016-02-12 13:16:43 UTC) #2
Camillo Bruni
lgtm
4 years, 10 months ago (2016-02-12 13:20:35 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1698463002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1698463002/1
4 years, 10 months ago (2016-02-12 13:27:41 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 10 months ago (2016-02-12 14:14:53 UTC) #6
commit-bot: I haz the power
4 years, 10 months ago (2016-02-12 14:15:12 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/2649611109db5f9d60b27c6b2b12e78e5ee9bb25
Cr-Commit-Position: refs/heads/master@{#33949}

Powered by Google App Engine
This is Rietveld 408576698