Retrieve bleeding edge push revision from trunk commit message.

tools/push-to-trunk/auto_roll.py

 #!/usr/bin/env python
 # Copyright 2013 the V8 project authors. All rights reserved.
 # Redistribution and use in source and binary forms, with or without
 # modification, are permitted provided that the following conditions are
 # met:
 #
 #     * Redistributions of source code must retain the above copyright
 #       notice, this list of conditions and the following disclaimer.
 #     * Redistributions in binary form must reproduce the above
 #       copyright notice, this list of conditions and the following
@@ skipping 87 matching lines @@
     if not match:
       self.Die("Could not extract current svn revision from log.")
     self.Persist("latest", match.group(1))
 
 
 class CheckLastPush(Step):
   MESSAGE = "Checking last V8 push to trunk."
 
   def RunStep(self):
     self.RestoreIfUnset("latest")
-    log = self.Git("svn log -1 --oneline ChangeLog").strip()
-    match = re.match(r"^r(\d+) \| Prepare push to trunk", log)
-    if match:
-      latest = int(self._state["latest"])
-      last_push = int(match.group(1))
-      # TODO(machebach): This metric counts all revisions. It could be
-      # improved by counting only the revisions on bleeding_edge.
-      if latest - last_push < 10:
-        # This makes sure the script doesn't push twice in a row when the cron
-        # job retries several times.
-        self.Die("Last push too recently: %d" % last_push)
+    push_pattern = "^Version [[:digit:]]*\.[[:digit:]]*\.[[:digit:]]* (based"

[Jakob Kummerow, 2014/02/19 12:44:49]

Same s/*/+/ comment here... this looks like a candidate for refactoring. Let's
add a helper to class Step, roughly:

def FindLastTrunkPush():
  push_pattern = "^Version [[:digit:]]+\.[[:digit:]]+\.[[:digit:]]+ (based"
  args = "log -1 --format=%%H --grep=\"%s\" svn/trunk" % push_pattern
  return self.Git(args).strip()

[Michael Achenbach, 2014/02/19 13:24:02]

Extract method: Done. Regarding +: see the other comment.

+    args = "log -1 --format=%%H --grep=\"%s\" svn/trunk" % push_pattern
+    last_push_hash = self.Git(args).strip()
+    last_push = int(self.Git("svn find-rev %s" % last_push_hash).strip())
+
+    # TODO(machebach): This metric counts all revisions. It could be

[Jakob Kummerow, 2014/02/19 12:44:49]

Who's machebach?

[Michael Achenbach, 2014/02/19 13:23:03]

Done.

+    # improved by counting only the revisions on bleeding_edge.
+    if int(self._state["latest"]) - last_push < 10:
+      # This makes sure the script doesn't push twice in a row when the cron
+      # job retries several times.
+      self.Die("Last push too recently: %d" % last_push)
 
 
 class FetchLKGR(Step):
   MESSAGE = "Fetching V8 LKGR."
 
   def RunStep(self):
     lkgr_url = "https://v8-status.appspot.com/lkgr"
     # Retry several times since app engine might have issues.
     self.Persist("lkgr", self.ReadURL(lkgr_url, wait_plan=[5, 20, 300, 300]))
 
@@ skipping 81 matching lines @@
   parser = BuildOptions()
   (options, args) = parser.parse_args()
   if not options.a or not options.c or not options.reviewer:
     print "You need to specify author, chromium src location and reviewer."
     parser.print_help()
     return 1
   RunAutoRoll(CONFIG, AutoRollOptions(options))
 
 if __name__ == "__main__":
   sys.exit(Main())