Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(25)

Issue 1698403004: headless: Add devtools discovery page (Closed)

Created:
4 years, 10 months ago by Sami
Modified:
4 years, 9 months ago
CC:
chromium-reviews, pfeldman, devtools-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

headless: Add devtools discovery page This page adds a generated discovery page which can be used to pick a tab to inspect using devtools. This is based on the similar page generated by Content Shell. BUG=546953 TEST=headless_shell --remote-debugging-port=9222 # Navigate to localhost:9222 to see the google.com tab. Committed: https://crrev.com/85c6b560c583cf265e4af5d68c9f07afb1fe74ca Cr-Commit-Position: refs/heads/master@{#378759}

Patch Set 1 #

Patch Set 2 : Rebased. #

Patch Set 3 : Build fix. #

Patch Set 4 : Rebased. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -5 lines) Patch
M headless/BUILD.gn View 1 4 chunks +11 lines, -0 lines 0 comments Download
M headless/lib/browser/headless_devtools.cc View 1 2 chunks +3 lines, -1 line 0 comments Download
A + headless/lib/resources/devtools_discovery_page.html View 1 chunk +1 line, -1 line 0 comments Download
A + headless/lib/resources/headless_lib_resources.grd View 1 chunk +4 lines, -3 lines 0 comments Download
M tools/gritsettings/resource_ids View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 20 (9 generated)
Sami
4 years, 10 months ago (2016-02-16 19:00:56 UTC) #3
Sami
4 years, 10 months ago (2016-02-17 10:23:52 UTC) #5
alex clarke (OOO till 29th)
lgtm
4 years, 10 months ago (2016-02-17 10:27:00 UTC) #6
Sami
Mattias, could you check tools/gritsettings/resource_ids please?
4 years, 9 months ago (2016-02-26 21:47:01 UTC) #8
Sami
Mattias, pinging as instructed :)
4 years, 9 months ago (2016-02-29 21:30:09 UTC) #9
Sami
Nico, could you please have a look at tools/gritsettings/resource_ids as Mattias doesn't seem to be ...
4 years, 9 months ago (2016-03-01 17:56:24 UTC) #11
Mattias Nissler (ping if slow)
Sorry for being unresponsive. Also, I'm not familiar enough with resource IDs to be a ...
4 years, 9 months ago (2016-03-02 08:38:46 UTC) #12
Nico
lgtm
4 years, 9 months ago (2016-03-02 09:32:05 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1698403004/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1698403004/60001
4 years, 9 months ago (2016-03-02 14:53:59 UTC) #16
commit-bot: I haz the power
Committed patchset #4 (id:60001)
4 years, 9 months ago (2016-03-02 16:13:12 UTC) #18
commit-bot: I haz the power
4 years, 9 months ago (2016-03-02 16:14:34 UTC) #20
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/85c6b560c583cf265e4af5d68c9f07afb1fe74ca
Cr-Commit-Position: refs/heads/master@{#378759}

Powered by Google App Engine
This is Rietveld 408576698