Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(147)

Unified Diff: src/crankshaft/hydrogen.cc

Issue 1698343002: [builtins] Move the Boolean constructor to C++. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Also remove it from ia32 of course. Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/crankshaft/hydrogen.h ('k') | src/full-codegen/arm/full-codegen-arm.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/crankshaft/hydrogen.cc
diff --git a/src/crankshaft/hydrogen.cc b/src/crankshaft/hydrogen.cc
index 526f3d7238b10735c11a34224f6f94b1f5bcd1b7..f26c44e939f7c0298349b40e08405a788f4b7376 100644
--- a/src/crankshaft/hydrogen.cc
+++ b/src/crankshaft/hydrogen.cc
@@ -12480,17 +12480,6 @@ void HOptimizedGraphBuilder::GenerateValueOf(CallRuntime* call) {
}
-void HOptimizedGraphBuilder::GenerateJSValueGetValue(CallRuntime* call) {
- DCHECK(call->arguments()->length() == 1);
- CHECK_ALIVE(VisitForValue(call->arguments()->at(0)));
- HValue* value = Pop();
- HInstruction* result = Add<HLoadNamedField>(
- value, nullptr,
- HObjectAccess::ForObservableJSObjectOffset(JSValue::kValueOffset));
- return ast_context()->ReturnInstruction(result, call->id());
-}
-
-
void HOptimizedGraphBuilder::GenerateIsDate(CallRuntime* call) {
DCHECK_EQ(1, call->arguments()->length());
CHECK_ALIVE(VisitForValue(call->arguments()->at(0)));
@@ -12533,43 +12522,6 @@ void HOptimizedGraphBuilder::GenerateTwoByteSeqStringSetChar(
}
-void HOptimizedGraphBuilder::GenerateSetValueOf(CallRuntime* call) {
- DCHECK(call->arguments()->length() == 2);
- CHECK_ALIVE(VisitForValue(call->arguments()->at(0)));
- CHECK_ALIVE(VisitForValue(call->arguments()->at(1)));
- HValue* value = Pop();
- HValue* object = Pop();
-
- // Check if object is a JSValue.
- IfBuilder if_objectisvalue(this);
- if_objectisvalue.If<HHasInstanceTypeAndBranch>(object, JS_VALUE_TYPE);
- if_objectisvalue.Then();
- {
- // Create in-object property store to kValueOffset.
- Add<HStoreNamedField>(object,
- HObjectAccess::ForObservableJSObjectOffset(JSValue::kValueOffset),
- value);
- if (!ast_context()->IsEffect()) {
- Push(value);
- }
- Add<HSimulate>(call->id(), FIXED_SIMULATE);
- }
- if_objectisvalue.Else();
- {
- // Nothing to do in this case.
- if (!ast_context()->IsEffect()) {
- Push(value);
- }
- Add<HSimulate>(call->id(), FIXED_SIMULATE);
- }
- if_objectisvalue.End();
- if (!ast_context()->IsEffect()) {
- Drop(1);
- }
- return ast_context()->ReturnValue(value);
-}
-
-
// Fast support for charCodeAt(n).
void HOptimizedGraphBuilder::GenerateStringCharCodeAt(CallRuntime* call) {
DCHECK(call->arguments()->length() == 2);
« no previous file with comments | « src/crankshaft/hydrogen.h ('k') | src/full-codegen/arm/full-codegen-arm.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698