Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4025)

Unified Diff: chrome/installer/setup/uninstall.h

Issue 169833003: Determine the path to setup.exe via PathService rather than the parsed (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: comment Created 6 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/installer/setup/setup_main.cc ('k') | chrome/installer/setup/uninstall.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/installer/setup/uninstall.h
diff --git a/chrome/installer/setup/uninstall.h b/chrome/installer/setup/uninstall.h
index 6b6311c983c42943283e7b3e074bbf63a85d7d86..96c34110a4d041829d7df582952ba32517d3753c 100644
--- a/chrome/installer/setup/uninstall.h
+++ b/chrome/installer/setup/uninstall.h
@@ -60,8 +60,9 @@ void RemoveChromeLegacyRegistryKeys(BrowserDistribution* dist,
//
// original_state: The installation state of all products on the system.
// installer_state: State associated with this operation.
-// setup_path: Path to the executable (setup.exe) as it will be copied
-// to temp folder before deleting Chrome folder.
+// setup_exe: The path to the currently running setup.exe. It and its containing
+// directories are left in-place if it is within the target directory of
+// the product being uninstalled.
// dist: Represents the distribution to be uninstalled.
// remove_all: Remove all shared files, registry entries as well.
// force_uninstall: Uninstall without prompting for user confirmation or
@@ -71,7 +72,7 @@ void RemoveChromeLegacyRegistryKeys(BrowserDistribution* dist,
installer::InstallStatus UninstallProduct(
const InstallationState& original_state,
const InstallerState& installer_state,
- const base::FilePath& setup_path,
+ const base::FilePath& setup_exe,
const Product& dist,
bool remove_all,
bool force_uninstall,
@@ -84,13 +85,14 @@ installer::InstallStatus UninstallProduct(
//
// original_state: The installation state of all products on the system.
// installer_state: State associated with this operation.
-// cmd_line: CommandLine that contains information about the command that
-// was used to launch current uninstaller.
+// setup_exe: The path to the currently running setup.exe, which will be moved
+// into a temporary directory to allow for deletion of the installation
+// directory.
// uninstall_status: the uninstall status so far (may change during invocation).
void CleanUpInstallationDirectoryAfterUninstall(
const InstallationState& original_state,
const InstallerState& installer_state,
- const CommandLine& cmd_line,
+ const base::FilePath& setup_exe,
InstallStatus* uninstall_status);
} // namespace installer
« no previous file with comments | « chrome/installer/setup/setup_main.cc ('k') | chrome/installer/setup/uninstall.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698