Determine the path to setup.exe via PathService rather than the parsed

Determine the path to setup.exe via PathService rather than the parsed
command line. Only the former is authoritative.

BUG=141168
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=251720

[grt (UTC plus 2), 2014-02-17 18:40:19]

gab: please take a look. this cleanup unblocks a mini_installer change that cdn
is working on. thanks.

[gab, 2014-02-17 19:35:02]

lgtm % nits

https://codereview.chromium.org/169833003/diff/1/chrome/installer/setup/setup...
File chrome/installer/setup/setup_main.cc (right):

https://codereview.chromium.org/169833003/diff/1/chrome/installer/setup/setup...
chrome/installer/setup/setup_main.cc:1750: // via the path service rather than
the CommandLine since only the former is
I don't understand what you mean by "for use throughout all operations via the
path service"?

Did you mean "for use throughout the installer" or something else?

https://codereview.chromium.org/169833003/diff/1/chrome/installer/setup/setup...
chrome/installer/setup/setup_main.cc:1754: return installer::OS_ERROR;
NOTREACHED() on top of the error return; makes for easier debugging in Debug
builds (should this EVER occur).

[grt (UTC plus 2), 2014-02-17 21:28:29]

thanks

https://codereview.chromium.org/169833003/diff/1/chrome/installer/setup/setup...
File chrome/installer/setup/setup_main.cc (right):

https://codereview.chromium.org/169833003/diff/1/chrome/installer/setup/setup...
chrome/installer/setup/setup_main.cc:1750: // via the path service rather than
the CommandLine since only the former is
On 2014/02/17 19:35:02, gab wrote:
> I don't understand what you mean by "for use throughout all operations via the
> path service"?
> 
> Did you mean "for use throughout the installer" or something else?

yeah. setup.exe does many different things depending on how it's invoked.

https://codereview.chromium.org/169833003/diff/1/chrome/installer/setup/setup...
chrome/installer/setup/setup_main.cc:1754: return installer::OS_ERROR;
On 2014/02/17 19:35:02, gab wrote:
> NOTREACHED() on top of the error return; makes for easier debugging in Debug
> builds (should this EVER occur).

okay. i actually had it there for a bit, but removed it since i'm pretty sure
it'll never happen.

[grt (UTC plus 2), 2014-02-17 21:28:33]

The CQ bit was checked by grt@chromium.org

[commit-bot: I haz the power, 2014-02-17 21:28:44]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/grt@chromium.org/169833003/130001

[gab, 2014-02-17 21:55:23]

https://codereview.chromium.org/169833003/diff/130001/chrome/installer/setup/...
File chrome/installer/setup/setup_main.cc (right):

https://codereview.chromium.org/169833003/diff/130001/chrome/installer/setup/...
chrome/installer/setup/setup_main.cc:1750: // operations via the path service
rather than the CommandLine since only the
What I meant is that this sentence is grammatically confusing:

I think you mean:
"Get X via the path service"
where X = "the path to the current executable for use throughout all installer
operations"

but I'm reading it more like:

"Get X for use through all the Ys"
where Y = "installer operations via the path service.

which doesn't really make sense... hence my confusion.


How about:
// Get the path to the current executable for use throughout all installer
operations. Obtain the path through the path service rather than the CommandLine
since...

[gab, 2014-02-17 21:56:04]

The CQ bit was unchecked by gab@chromium.org

[grt (UTC plus 2), 2014-02-18 00:15:42]

i'd like to get this into the next canary. i'm happy to change the comment
further in a follow-on commit if you'd like, but please don't prevent this one
from passing the CQ. thanks.

https://codereview.chromium.org/169833003/diff/130001/chrome/installer/setup/...
File chrome/installer/setup/setup_main.cc (right):

https://codereview.chromium.org/169833003/diff/130001/chrome/installer/setup/...
chrome/installer/setup/setup_main.cc:1750: // operations via the path service
rather than the CommandLine since only the
On 2014/02/17 21:55:23, gab wrote:
> What I meant is that this sentence is grammatically confusing:
> 
> I think you mean:
> "Get X via the path service"
> where X = "the path to the current executable for use throughout all installer
> operations"
> 
> but I'm reading it more like:
> 
> "Get X for use through all the Ys"
> where Y = "installer operations via the path service.
> 
> which doesn't really make sense... hence my confusion.
> 
> 
> How about:
> // Get the path to the current executable for use throughout all installer
> operations. Obtain the path through the path service rather than the
CommandLine
> since...

expanded comment in an attempt to clarify things.

[grt (UTC plus 2), 2014-02-18 00:15:47]

The CQ bit was checked by grt@chromium.org

[commit-bot: I haz the power, 2014-02-18 00:15:51]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/grt@chromium.org/169833003/300001

[gab, 2014-02-18 03:03:41]

Thanks, lgtm++

[commit-bot: I haz the power, 2014-02-18 03:25:46]

Change committed as 251720