Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(158)

Issue 1698323004: Remove apparent duplicate call to PrepareForScriptLoading in Dartium (Closed)

Created:
4 years, 10 months ago by Alan Knight
Modified:
4 years, 10 months ago
Reviewers:
Cutch, siva, Jacob
CC:
reviews_dartlang.org, turnidge, rmacnak, vm-dev_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Remove apparent duplicate call to PrepareForScriptLoading in Dartium BUG= Committed: https://github.com/dart-lang/sdk/commit/66d4d7665c413880c818331e17e4b8ae0b87e3b5

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -5 lines) Patch
M runtime/bin/vmservice_dartium.cc View 1 chunk +0 lines, -5 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
Alan Knight
I was seeing a snap in debug mode, violating the assert in set_builtin_lib it had ...
4 years, 10 months ago (2016-02-16 20:55:46 UTC) #2
Cutch
NLGTM Where is the other call to PrepareForScriptLoading happening?
4 years, 10 months ago (2016-02-16 20:59:24 UTC) #4
Alan Knight
I don't know. I was just trying to get more information by removing that call ...
4 years, 10 months ago (2016-02-16 21:09:39 UTC) #5
Cutch
On 2016/02/16 21:09:39, Alan Knight wrote: > I don't know. I was just trying to ...
4 years, 10 months ago (2016-02-17 18:22:22 UTC) #6
Alan Knight
Great, thanks!
4 years, 10 months ago (2016-02-17 18:25:41 UTC) #7
Alan Knight
4 years, 10 months ago (2016-02-17 18:27:01 UTC) #9
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
66d4d7665c413880c818331e17e4b8ae0b87e3b5 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698