Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(455)

Issue 1698323003: Don't include ICData::owner_ in precompiled snapshots. (Closed)

Created:
4 years, 10 months ago by rmacnak
Modified:
4 years, 10 months ago
Reviewers:
srdjan
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Don't include ICData::owner_ in precompiled snapshots. It can refer to a function that has always been inlined and that the tree shaker has removed. precompiled dart2js x64 21647652 -> 21437594 (-0.97%) R=srdjan@google.com Committed: https://github.com/dart-lang/sdk/commit/c03761a21adf348b14c3607c16c4842cd256ff2c

Patch Set 1 #

Patch Set 2 : #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -7 lines) Patch
M runtime/vm/object.cc View 1 chunk +0 lines, -1 line 0 comments Download
M runtime/vm/raw_object.h View 1 chunk +7 lines, -4 lines 0 comments Download
M runtime/vm/raw_object_snapshot.cc View 2 chunks +9 lines, -2 lines 2 comments Download

Messages

Total messages: 6 (2 generated)
rmacnak
4 years, 10 months ago (2016-02-16 20:16:24 UTC) #2
srdjan
lgtm https://codereview.chromium.org/1698323003/diff/20001/runtime/vm/raw_object_snapshot.cc File runtime/vm/raw_object_snapshot.cc (right): https://codereview.chromium.org/1698323003/diff/20001/runtime/vm/raw_object_snapshot.cc#newcode2030 runtime/vm/raw_object_snapshot.cc:2030: // refer to a function which was always ...
4 years, 10 months ago (2016-02-16 20:36:43 UTC) #3
rmacnak
Committed patchset #2 (id:20001) manually as c03761a21adf348b14c3607c16c4842cd256ff2c (presubmit successful).
4 years, 10 months ago (2016-02-16 21:38:33 UTC) #5
rmacnak
4 years, 10 months ago (2016-02-16 21:39:17 UTC) #6
Message was sent while issue was closed.
https://codereview.chromium.org/1698323003/diff/20001/runtime/vm/raw_object_s...
File runtime/vm/raw_object_snapshot.cc (right):

https://codereview.chromium.org/1698323003/diff/20001/runtime/vm/raw_object_s...
runtime/vm/raw_object_snapshot.cc:2030: // refer to a function which was always
inlined and no longer need.
On 2016/02/16 20:36:42, srdjan wrote:
> s/need/needed/

Done.

Powered by Google App Engine
This is Rietveld 408576698