Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(27)

Issue 1698303002: Revert 1675973002 and 1683213002. (Closed)

Created:
4 years, 10 months ago by phoglund_chromium
Modified:
4 years, 10 months ago
CC:
chromium-reviews, krit, pdr+graphicswatchlist_chromium.org, drott+blinkwatch_chromium.org, blink-reviews-platform-graphics_chromium.org, vmpstr+blinkwatch_chromium.org, dshwang, jbroman, Justin Novosad, danakj+watch_chromium.org, Rik, f(malita), blink-reviews, piman+watch_chromium.org, kinuko+watch, Stephen Chennney, rwlbuis
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert 1675973002 and 1683213002. Reason for revert: Speculative revert: appears to break printing/webgl-oversized-printing.html on Linux MSAN: https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Linux%20MSAN/builds/8511 and possibly a bunch of other webkit tests. Revert "Prefer to use the OES_depth24 extension for WebGL's depth-only back buffers." This reverts commit 2374479265b26ba0a4a658582b068a4526220774. Revert "Clean up drawing buffer code." This reverts commit d89c4e01716053d7bd4642f42c8d4a1ecefcaf92. BUG=584807 TBR=kbr@chromium.org Committed: https://crrev.com/484475eb5757acd278b7ca323d2b2a2f074d196e Cr-Commit-Position: refs/heads/master@{#375550}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+51 lines, -41 lines) Patch
M third_party/WebKit/Source/platform/graphics/gpu/DrawingBuffer.h View 3 chunks +7 lines, -11 lines 0 comments Download
M third_party/WebKit/Source/platform/graphics/gpu/DrawingBuffer.cpp View 7 chunks +42 lines, -29 lines 0 comments Download
M third_party/WebKit/Source/platform/graphics/gpu/DrawingBufferTest.cpp View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 9 (5 generated)
phoglund_chromium
I'm going to try this to see if this greens up some webkit tests, feel ...
4 years, 10 months ago (2016-02-16 11:02:53 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1698303002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1698303002/1
4 years, 10 months ago (2016-02-16 11:02:56 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 10 months ago (2016-02-16 12:10:31 UTC) #7
commit-bot: I haz the power
4 years, 10 months ago (2016-02-16 22:52:13 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/484475eb5757acd278b7ca323d2b2a2f074d196e
Cr-Commit-Position: refs/heads/master@{#375550}

Powered by Google App Engine
This is Rietveld 408576698