editor/util/plugins/com.google.dart.java2dart/src/com/google/dart/java2dart/processor/PropertySemanticProcessor.java - Issue 16983008: Fix build after analyzer_experimental changes

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: editor/util/plugins/com.google.dart.java2dart/src/com/google/dart/java2dart/processor/PropertySemanticProcessor.java

Issue 16983008: Fix build after analyzer_experimental changes (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Created 7 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « editor/util/plugins/com.google.dart.java2dart/src/com/google/dart/java2dart/engine/MainEngine.java ('k') | editor/util/plugins/com.google.dart.java2dart_test/src/com/google/dart/java2dart/processor/PropertySemanticProcessorTest.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: editor/util/plugins/com.google.dart.java2dart/src/com/google/dart/java2dart/processor/PropertySemanticProcessor.java

diff --git a/editor/util/plugins/com.google.dart.java2dart/src/com/google/dart/java2dart/processor/PropertySemanticProcessor.java b/editor/util/plugins/com.google.dart.java2dart/src/com/google/dart/java2dart/processor/PropertySemanticProcessor.java

index a4bf8a2715d6373680a1a70a733012f8c24c057c..d6d98090d43a2ee5e1b3bfcee3270da014a53c2a 100644

--- a/editor/util/plugins/com.google.dart.java2dart/src/com/google/dart/java2dart/processor/PropertySemanticProcessor.java

+++ b/editor/util/plugins/com.google.dart.java2dart/src/com/google/dart/java2dart/processor/PropertySemanticProcessor.java

@@ -86,6 +86,9 @@ public class PropertySemanticProcessor extends SemanticProcessor {

List<FormalParameter> parameters = node.getParameters().getParameters();

// getter

if (parameters.isEmpty() && (hasPrefix(name, "get") || hasPrefix(name, "is"))) {

+ if (!context.canMakeProperty(nameNode)) {

+ return null;

+ }

String propertyName = StringUtils.uncapitalize(StringUtils.removeStart(name, "get"));

// rename references

context.renameIdentifier(nameNode, propertyName);

@@ -114,6 +117,9 @@ public class PropertySemanticProcessor extends SemanticProcessor {

// setter

if (hasPrefix(name, "set") && parameters.size() == 1

&& isValidSetterType(node.getReturnType())) {

+ if (!context.canMakeProperty(nameNode)) {

+ return null;

+ }

String propertyName = StringUtils.uncapitalize(StringUtils.removeStart(name, "set"));

// rename references

context.renameIdentifier(nameNode, propertyName);