Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1)

Side by Side Diff: src/mips/stub-cache-mips.cc

Issue 16983002: MIPS: Only extend storage if FIELD (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Created 7 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 514 matching lines...) Expand 10 before | Expand all | Expand 10 after
525 525
526 __ bind(&do_store); 526 __ bind(&do_store);
527 __ sdc1(f4, FieldMemOperand(storage_reg, HeapNumber::kValueOffset)); 527 __ sdc1(f4, FieldMemOperand(storage_reg, HeapNumber::kValueOffset));
528 } 528 }
529 529
530 // Stub never generated for non-global objects that require access 530 // Stub never generated for non-global objects that require access
531 // checks. 531 // checks.
532 ASSERT(object->IsJSGlobalProxy() || !object->IsAccessCheckNeeded()); 532 ASSERT(object->IsJSGlobalProxy() || !object->IsAccessCheckNeeded());
533 533
534 // Perform map transition for the receiver if necessary. 534 // Perform map transition for the receiver if necessary.
535 if (object->map()->unused_property_fields() == 0) { 535 if (details.type() == FIELD &&
536 object->map()->unused_property_fields() == 0) {
536 // The properties must be extended before we can store the value. 537 // The properties must be extended before we can store the value.
537 // We jump to a runtime call that extends the properties array. 538 // We jump to a runtime call that extends the properties array.
538 __ push(receiver_reg); 539 __ push(receiver_reg);
539 __ li(a2, Operand(transition)); 540 __ li(a2, Operand(transition));
540 __ Push(a2, a0); 541 __ Push(a2, a0);
541 __ TailCallExternalReference( 542 __ TailCallExternalReference(
542 ExternalReference(IC_Utility(IC::kSharedStoreIC_ExtendStorage), 543 ExternalReference(IC_Utility(IC::kSharedStoreIC_ExtendStorage),
543 masm->isolate()), 544 masm->isolate()),
544 3, 1); 545 3, 1);
545 return; 546 return;
(...skipping 3188 matching lines...) Expand 10 before | Expand all | Expand 10 after
3734 TailCallBuiltin(masm, Builtins::kKeyedStoreIC_Slow); 3735 TailCallBuiltin(masm, Builtins::kKeyedStoreIC_Slow);
3735 } 3736 }
3736 } 3737 }
3737 3738
3738 3739
3739 #undef __ 3740 #undef __
3740 3741
3741 } } // namespace v8::internal 3742 } } // namespace v8::internal
3742 3743
3743 #endif // V8_TARGET_ARCH_MIPS 3744 #endif // V8_TARGET_ARCH_MIPS
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698