Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(558)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1698283002: Fix logcat regex in asan stack trace symbolizer. (Closed)

Created:
4 years, 10 months ago by bpastene
Modified:
4 years, 10 months ago
Reviewers:
jbudorick
CC:
chromium-reviews, jbudorick+watch_chromium.org, mikecase+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix logcat regex in asan stack trace symbolizer. BUG=549348 Committed: https://crrev.com/0fe335ccfa0410b7c1646770a9ba7dd662dd5214 Cr-Commit-Position: refs/heads/master@{#375589}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Greed is good #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M build/android/asan_symbolize.py View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 10 (3 generated)
bpastene
4 years, 10 months ago (2016-02-16 10:07:53 UTC) #2
jbudorick
https://codereview.chromium.org/1698283002/diff/1/build/android/asan_symbolize.py File build/android/asan_symbolize.py (right): https://codereview.chromium.org/1698283002/diff/1/build/android/asan_symbolize.py#newcode24 build/android/asan_symbolize.py:24: _RE_ASAN = re.compile(r'(.*?)(#\S*?)\s+?(\S*?)\s+?\((.*?)\+(.*?)\)') Why \s+? instead of \s+ (or, ...
4 years, 10 months ago (2016-02-16 11:46:07 UTC) #3
bpastene
https://codereview.chromium.org/1698283002/diff/1/build/android/asan_symbolize.py File build/android/asan_symbolize.py (right): https://codereview.chromium.org/1698283002/diff/1/build/android/asan_symbolize.py#newcode24 build/android/asan_symbolize.py:24: _RE_ASAN = re.compile(r'(.*?)(#\S*?)\s+?(\S*?)\s+?\((.*?)\+(.*?)\)') On 2016/02/16 11:46:07, jbudorick wrote: > ...
4 years, 10 months ago (2016-02-16 14:46:42 UTC) #4
jbudorick
lgtm
4 years, 10 months ago (2016-02-16 14:55:19 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1698283002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1698283002/20001
4 years, 10 months ago (2016-02-16 15:03:10 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 10 months ago (2016-02-16 16:18:21 UTC) #8
commit-bot: I haz the power
4 years, 10 months ago (2016-02-16 22:53:07 UTC) #10
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/0fe335ccfa0410b7c1646770a9ba7dd662dd5214
Cr-Commit-Position: refs/heads/master@{#375589}

Powered by Google App Engine
This is Rietveld 408576698