Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(276)

Issue 1698273002: Revert of [turbofan] Combine GenericLoweringPhase and ChangeLoweringPhase. (Closed)

Created:
4 years, 10 months ago by Benedikt Meurer
Modified:
4 years, 10 months ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@TurboFan_Pipeline
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Revert of [turbofan] Combine GenericLoweringPhase and ChangeLoweringPhase. (patchset #1 id:1 of https://codereview.chromium.org/1697133002/ ) Reason for revert: Seems to tank stuff. Original issue's description: > [turbofan] Combine GenericLoweringPhase and ChangeLoweringPhase. > > There's no need to use a dedicated ChangeLoweringPhase before we go to > GenericLoweringPhase; instead that change lowering (which is really > simplified lowering by now) should run together with generic lowering. > > R=jarin@chromium.org > > Committed: https://crrev.com/0835ed9caf44427755065eb45f9187678ec9844c > Cr-Commit-Position: refs/heads/master@{#34008} TBR=jarin@chromium.org,bmeurer@google.com # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Committed: https://crrev.com/d057adc83ea31a50369b472a8c9a8329d7956feb Cr-Commit-Position: refs/heads/master@{#34019}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+32 lines, -13 lines) Patch
M src/compiler/pipeline.cc View 4 chunks +32 lines, -13 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
Benedikt Meurer
Created Revert of [turbofan] Combine GenericLoweringPhase and ChangeLoweringPhase.
4 years, 10 months ago (2016-02-16 08:25:07 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1698273002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1698273002/1
4 years, 10 months ago (2016-02-16 08:25:11 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 10 months ago (2016-02-16 08:25:22 UTC) #3
commit-bot: I haz the power
4 years, 10 months ago (2016-02-16 08:25:45 UTC) #5
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/d057adc83ea31a50369b472a8c9a8329d7956feb
Cr-Commit-Position: refs/heads/master@{#34019}

Powered by Google App Engine
This is Rietveld 408576698