Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
1698223002:
Remove UnwrapTraits (Closed)
DescriptionRemove UnwrapTraits
Remove UnwrapTraits::ForwardType, which is no longer used, and extract
UnwrapTraits::Unwrap to be non member function.
BUG=554299
Committed: https://crrev.com/463eb426b5621e116c2025e279e204cc483a7e29
Cr-Commit-Position: refs/heads/master@{#375576}
Patch Set 1 #Patch Set 2 : #
Total comments: 3
Messages
Total messages: 21 (9 generated)
The CQ bit was checked by tzik@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1698223002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1698223002/1
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)
The CQ bit was checked by tzik@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1698223002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1698223002/20001
Description was changed from ========== Remove UnwrapTraits BUG= ========== to ========== Remove UnwrapTraits Remove UnwrapTraits::ForwardType, which is no longer used, and extract UnwrapTraits::Unwrap to be non member function. BUG=554299 ==========
tzik@chromium.org changed reviewers: + thakis@chromium.org
PTAL
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
lgtm! https://codereview.chromium.org/1698223002/diff/20001/base/bind_helpers.h File base/bind_helpers.h (right): https://codereview.chromium.org/1698223002/diff/20001/base/bind_helpers.h#new... base/bind_helpers.h:359: // This conundrum cannot be solved without either C++11 rvalue references or do we still need this type?
The CQ bit was checked by thakis@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1698223002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1698223002/20001
Message was sent while issue was closed.
Description was changed from ========== Remove UnwrapTraits Remove UnwrapTraits::ForwardType, which is no longer used, and extract UnwrapTraits::Unwrap to be non member function. BUG=554299 ========== to ========== Remove UnwrapTraits Remove UnwrapTraits::ForwardType, which is no longer used, and extract UnwrapTraits::Unwrap to be non member function. BUG=554299 ==========
Message was sent while issue was closed.
Committed patchset #2 (id:20001)
Message was sent while issue was closed.
https://codereview.chromium.org/1698223002/diff/20001/base/bind_helpers.h File base/bind_helpers.h (right): https://codereview.chromium.org/1698223002/diff/20001/base/bind_helpers.h#new... base/bind_helpers.h:359: // This conundrum cannot be solved without either C++11 rvalue references or On 2016/02/16 14:57:10, Nico wrote: > do we still need this type? Yes, we still need this for a while for Run() impl. Though we can already Bind movable-but-not-copyable types since we start using rvalue reference on Bind, we still need this to annotate that we should move out the bound argument into the receiver.
Message was sent while issue was closed.
https://codereview.chromium.org/1698223002/diff/20001/base/bind_helpers.h File base/bind_helpers.h (right): https://codereview.chromium.org/1698223002/diff/20001/base/bind_helpers.h#new... base/bind_helpers.h:359: // This conundrum cannot be solved without either C++11 rvalue references or On 2016/02/16 15:22:17, tzik wrote: > On 2016/02/16 14:57:10, Nico wrote: > > do we still need this type? > > Yes, we still need this for a while for Run() impl. > Though we can already Bind movable-but-not-copyable types since we start using > rvalue reference on Bind, we still need this to annotate that we should move out > the bound argument into the receiver. Maybe the comment could use updating then :-)
Message was sent while issue was closed.
On 2016/02/16 15:24:22, Nico wrote: > https://codereview.chromium.org/1698223002/diff/20001/base/bind_helpers.h > File base/bind_helpers.h (right): > > https://codereview.chromium.org/1698223002/diff/20001/base/bind_helpers.h#new... > base/bind_helpers.h:359: // This conundrum cannot be solved without either C++11 > rvalue references or > On 2016/02/16 15:22:17, tzik wrote: > > On 2016/02/16 14:57:10, Nico wrote: > > > do we still need this type? > > > > Yes, we still need this for a while for Run() impl. > > Though we can already Bind movable-but-not-copyable types since we start using > > rvalue reference on Bind, we still need this to annotate that we should move > out > > the bound argument into the receiver. > > Maybe the comment could use updating then :-) Hm, yeah. Some comments are outdated here and elsewhere... Needs update.
Message was sent while issue was closed.
Description was changed from ========== Remove UnwrapTraits Remove UnwrapTraits::ForwardType, which is no longer used, and extract UnwrapTraits::Unwrap to be non member function. BUG=554299 ========== to ========== Remove UnwrapTraits Remove UnwrapTraits::ForwardType, which is no longer used, and extract UnwrapTraits::Unwrap to be non member function. BUG=554299 Committed: https://crrev.com/463eb426b5621e116c2025e279e204cc483a7e29 Cr-Commit-Position: refs/heads/master@{#375576} ==========
Message was sent while issue was closed.
Patchset 2 (id:??) landed as https://crrev.com/463eb426b5621e116c2025e279e204cc483a7e29 Cr-Commit-Position: refs/heads/master@{#375576} |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
