Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(723)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1698133002: [wasm] Clean up handling of function names. (Closed)

Created:
4 years, 10 months ago by titzer
Modified:
4 years, 10 months ago
Reviewers:
ahaas
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[wasm] Clean up handling of function names. R=ahaas@chromium.org BUG= Committed: https://crrev.com/3a0377a48d1fca58b4efb460f3fd85a2e25866e9 Cr-Commit-Position: refs/heads/master@{#33999}

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+48 lines, -28 lines) Patch
M src/compiler/wasm-compiler.h View 1 chunk +1 line, -1 line 0 comments Download
M src/compiler/wasm-compiler.cc View 4 chunks +7 lines, -10 lines 0 comments Download
M src/wasm/module-decoder.cc View 3 chunks +4 lines, -8 lines 0 comments Download
M src/wasm/wasm-module.h View 4 chunks +13 lines, -2 lines 1 comment Download
M src/wasm/wasm-module.cc View 5 chunks +20 lines, -6 lines 0 comments Download
M test/cctest/wasm/wasm-run-utils.h View 1 chunk +3 lines, -1 line 0 comments Download

Messages

Total messages: 8 (2 generated)
titzer
4 years, 10 months ago (2016-02-15 13:36:52 UTC) #1
ahaas
lgtm https://codereview.chromium.org/1698133002/diff/1/src/wasm/wasm-module.h File src/wasm/wasm-module.h (right): https://codereview.chromium.org/1698133002/diff/1/src/wasm/wasm-module.h#newcode198 src/wasm/wasm-module.h:198: struct WasmFunctionName { What about calling this struct ...
4 years, 10 months ago (2016-02-15 14:44:40 UTC) #2
titzer
On 2016/02/15 14:44:40, ahaas wrote: > lgtm > > https://codereview.chromium.org/1698133002/diff/1/src/wasm/wasm-module.h > File src/wasm/wasm-module.h (right): > ...
4 years, 10 months ago (2016-02-15 15:58:20 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1698133002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1698133002/1
4 years, 10 months ago (2016-02-15 15:58:32 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 10 months ago (2016-02-15 16:00:00 UTC) #6
commit-bot: I haz the power
4 years, 10 months ago (2016-02-15 16:00:25 UTC) #8
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/3a0377a48d1fca58b4efb460f3fd85a2e25866e9
Cr-Commit-Position: refs/heads/master@{#33999}

Powered by Google App Engine
This is Rietveld 408576698