Issue 169813004: Revert of Move TextInputController from CppBoundClass to gin::Wrappable.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 169813004: Revert of Move TextInputController from CppBoundClass to gin::Wrappable. (Closed)

Created:
6 years, 10 months ago by tkent

Modified:
6 years, 10 months ago

Reviewers:
tfarina, jochen (gone - plz use gerrit)

CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam, jochen+watch_chromium.org, haraken

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Revert of Move TextInputController from CppBoundClass to gin::Wrappable. (https://codereview.chromium.org/144013010/) Reason for revert: Broke LayoutTests/editing/selection/move-left-right.html, which uses TextInputController. Original issue's description: > Move TextInputController from CppBoundClass to gin::Wrappable. > > Also, change the class to use chromium coding style. > > BUG=297480, 331301 > R=jochen@chromium.org > > Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=251692 TBR=jochen@chromium.org,tfarina@chromium.org NOTREECHECKS=true NOTRY=true BUG=297480, 331301 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=251714

Created: 6 years, 10 months ago

(Patch set is too large to download)

	Unified diffs	Side-by-side diffs	Stats (+244 lines, -317 lines)			Patch
M	content/content_shell.gypi	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	content/shell/renderer/test_runner/TestInterfaces.h	View	3 chunks	+2 lines, -2 lines	0 comments	Download
M	content/shell/renderer/test_runner/TestInterfaces.cpp	View	5 chunks	+5 lines, -5 lines	0 comments	Download
A	content/shell/renderer/test_runner/TextInputController.h	View	1 chunk	+42 lines, -0 lines	0 comments	Download
A	content/shell/renderer/test_runner/TextInputController.cpp	View	1 chunk	+193 lines, -0 lines	0 comments	Download
D	content/shell/renderer/test_runner/text_input_controller.h	View	1 chunk	+0 lines, -56 lines	0 comments	Download
D	content/shell/renderer/test_runner/text_input_controller.cc	View	1 chunk	+0 lines, -252 lines	0 comments	Download

Total messages: 3 (0 generated)

tkent

Created Revert of Move TextInputController from CppBoundClass to gin::Wrappable.

6 years, 10 months ago (2014-02-18 00:41:57 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tkent@chromium.org/169813004/1

6 years, 10 months ago (2014-02-18 00:42:05 UTC) #2

Message was sent while issue was closed.

Change committed as 251714