Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(59)

Unified Diff: chrome/browser/resources/settings/site_settings_page/site_settings_page.js

Issue 1698093007: Convert SiteSettingsCategory to use the HostContentSettingsMap instead of (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/resources/settings/site_settings_page/site_settings_page.js
diff --git a/chrome/browser/resources/settings/site_settings_page/site_settings_page.js b/chrome/browser/resources/settings/site_settings_page/site_settings_page.js
index d771117485502aefe58e4744bcfa9074ef50ae25..47f0e0f60eca1d31a11bee857dfe476ab5860c30 100644
--- a/chrome/browser/resources/settings/site_settings_page/site_settings_page.js
+++ b/chrome/browser/resources/settings/site_settings_page/site_settings_page.js
@@ -69,29 +69,33 @@ Polymer({
* @param {number} category The category to add.
*/
addCategory: function(category) {
- var root = this.$.list;
- var paperIcon = document.createElement('paper-icon-item');
- paperIcon.addEventListener('tap', this.onTapCategory.bind(this));
+ var self = this;
tommycli 2016/02/17 18:18:06 nit: same comment. Does .bind(this) do the trick i
Finnur 2016/02/18 20:38:18 Done.
+ this.$.prefsApi.getDefaultValueForContentType(category).
+ then(function(enabled) {
+ var root = self.$.list;
+ var paperIcon = document.createElement('paper-icon-item');
+ paperIcon.addEventListener('tap', self.onTapCategory.bind(self));
- var ironIcon = document.createElement('iron-icon');
- ironIcon.setAttribute('icon', this.computeIconForContentCategory(category));
- ironIcon.setAttribute('item-icon', '');
+ var ironIcon = document.createElement('iron-icon');
+ ironIcon.setAttribute('icon',
+ self.computeIconForContentCategory(category));
+ ironIcon.setAttribute('item-icon', '');
- var description = document.createElement('div');
- description.setAttribute('class', 'flex');
- description.appendChild(
- document.createTextNode(this.computeTitleForContentCategory(category)));
- var setting = document.createElement('div');
- setting.setAttribute('class', 'option-value');
+ var description = document.createElement('div');
+ description.setAttribute('class', 'flex');
+ description.appendChild(document.createTextNode(
+ self.computeTitleForContentCategory(category)));
+ var setting = document.createElement('div');
+ setting.setAttribute('class', 'option-value');
- setting.appendChild(document.createTextNode(
- this.computeCategoryDesc(
- category, this.isCategoryAllowed(category), false)));
+ setting.appendChild(document.createTextNode(
+ self.computeCategoryDesc(category, enabled, false)));
- paperIcon.appendChild(ironIcon);
- paperIcon.appendChild(description);
- paperIcon.appendChild(setting);
- root.appendChild(paperIcon);
+ paperIcon.appendChild(ironIcon);
+ paperIcon.appendChild(description);
+ paperIcon.appendChild(setting);
+ root.appendChild(paperIcon);
+ });
},
/**

Powered by Google App Engine
This is Rietveld 408576698