Chromium Code Reviews| Index: chrome/browser/resources/settings/site_settings_page/site_settings_page.js |
| diff --git a/chrome/browser/resources/settings/site_settings_page/site_settings_page.js b/chrome/browser/resources/settings/site_settings_page/site_settings_page.js |
| index d771117485502aefe58e4744bcfa9074ef50ae25..47f0e0f60eca1d31a11bee857dfe476ab5860c30 100644 |
| --- a/chrome/browser/resources/settings/site_settings_page/site_settings_page.js |
| +++ b/chrome/browser/resources/settings/site_settings_page/site_settings_page.js |
| @@ -69,29 +69,33 @@ Polymer({ |
| * @param {number} category The category to add. |
| */ |
| addCategory: function(category) { |
| - var root = this.$.list; |
| - var paperIcon = document.createElement('paper-icon-item'); |
| - paperIcon.addEventListener('tap', this.onTapCategory.bind(this)); |
| + var self = this; |
|
tommycli
2016/02/17 18:18:06
nit: same comment. Does .bind(this) do the trick i
Finnur
2016/02/18 20:38:18
Done.
|
| + this.$.prefsApi.getDefaultValueForContentType(category). |
| + then(function(enabled) { |
| + var root = self.$.list; |
| + var paperIcon = document.createElement('paper-icon-item'); |
| + paperIcon.addEventListener('tap', self.onTapCategory.bind(self)); |
| - var ironIcon = document.createElement('iron-icon'); |
| - ironIcon.setAttribute('icon', this.computeIconForContentCategory(category)); |
| - ironIcon.setAttribute('item-icon', ''); |
| + var ironIcon = document.createElement('iron-icon'); |
| + ironIcon.setAttribute('icon', |
| + self.computeIconForContentCategory(category)); |
| + ironIcon.setAttribute('item-icon', ''); |
| - var description = document.createElement('div'); |
| - description.setAttribute('class', 'flex'); |
| - description.appendChild( |
| - document.createTextNode(this.computeTitleForContentCategory(category))); |
| - var setting = document.createElement('div'); |
| - setting.setAttribute('class', 'option-value'); |
| + var description = document.createElement('div'); |
| + description.setAttribute('class', 'flex'); |
| + description.appendChild(document.createTextNode( |
| + self.computeTitleForContentCategory(category))); |
| + var setting = document.createElement('div'); |
| + setting.setAttribute('class', 'option-value'); |
| - setting.appendChild(document.createTextNode( |
| - this.computeCategoryDesc( |
| - category, this.isCategoryAllowed(category), false))); |
| + setting.appendChild(document.createTextNode( |
| + self.computeCategoryDesc(category, enabled, false))); |
| - paperIcon.appendChild(ironIcon); |
| - paperIcon.appendChild(description); |
| - paperIcon.appendChild(setting); |
| - root.appendChild(paperIcon); |
| + paperIcon.appendChild(ironIcon); |
| + paperIcon.appendChild(description); |
| + paperIcon.appendChild(setting); |
| + root.appendChild(paperIcon); |
| + }); |
| }, |
| /** |