chrome/browser/resources/settings/site_settings/site_settings_behavior.js - Issue 1698093007: Convert SiteSettingsCategory to use the HostContentSettingsMap instead of

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/resources/settings/site_settings/site_settings_behavior.js

Issue 1698093007: Convert SiteSettingsCategory to use the HostContentSettingsMap instead of (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Address feedback Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/resources/settings/site_settings/compiled_resources.gyp ('k') | chrome/browser/resources/settings/site_settings/site_settings_category.html » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/resources/settings/site_settings/site_settings_behavior.js

diff --git a/chrome/browser/resources/settings/site_settings/site_settings_behavior.js b/chrome/browser/resources/settings/site_settings/site_settings_behavior.js

index 3c9c2f4e7452b39b409d1b6fe1804d97033ed269..7ffd765aeb05e99ad336f75c566489babca4fd9d 100644

--- a/chrome/browser/resources/settings/site_settings/site_settings_behavior.js

+++ b/chrome/browser/resources/settings/site_settings/site_settings_behavior.js

@@ -17,22 +17,6 @@ var SiteSettingsBehaviorImpl = {

/**

- * Returns whether the category default is set to enabled or not.

- * @param {number} category The category to check.

- * @return {boolean} True if the category default is set to enabled.

- * @protected

- */

- isCategoryAllowed: function(category) {

- var pref = this.getPref(this.computeCategoryPrefName(category));

- // FullScreen is Allow vs. Ask.

- if (category == settings.ContentSettingsTypes.FULLSCREEN)

- return pref.value != settings.PermissionValues.ASK;

- return pref.value != settings.PermissionValues.BLOCK;

- },

- /**

* Re-sets the category permission for a given origin.

* @param {string} origin The origin to change the permission for.

* @param {number} category The category permission to change.