Convert SiteSettingsCategory to use the HostContentSettingsMap instead of

chrome/browser/resources/settings/site_settings_page/site_settings_page.js

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 /**
  * @fileoverview
  * 'settings-site-settings-page' is the settings page containing privacy and
  * security site settings.
  *
  * Example:
@@ skipping 51 matching lines @@
       this.addCategory(settings.ContentSettingsTypes.NOTIFICATIONS);
       this.addCategory(settings.ContentSettingsTypes.IMAGES);
     }.bind(this));
   },
 
   /**
    * Adds a single category to the page.
    * @param {number} category The category to add.
    */
   addCategory: function(category) {
-    var root = this.$.list;
-    var paperIcon = document.createElement('paper-icon-item');
-    paperIcon.addEventListener('tap', this.onTapCategory.bind(this));
+    var self = this;

[tommycli, 2016/02/17 18:18:06]

nit: same comment. Does .bind(this) do the trick instead of var self?

[Finnur, 2016/02/18 20:38:18]

Done.

+    this.$.prefsApi.getDefaultValueForContentType(category).
+        then(function(enabled) {
+          var root = self.$.list;
+          var paperIcon = document.createElement('paper-icon-item');
+          paperIcon.addEventListener('tap', self.onTapCategory.bind(self));
 
-    var ironIcon = document.createElement('iron-icon');
-    ironIcon.setAttribute('icon', this.computeIconForContentCategory(category));
-    ironIcon.setAttribute('item-icon', '');
+          var ironIcon = document.createElement('iron-icon');
+          ironIcon.setAttribute('icon',
+              self.computeIconForContentCategory(category));
+          ironIcon.setAttribute('item-icon', '');
 
-    var description = document.createElement('div');
-    description.setAttribute('class', 'flex');
-    description.appendChild(
-        document.createTextNode(this.computeTitleForContentCategory(category)));
-    var setting = document.createElement('div');
-    setting.setAttribute('class', 'option-value');
+          var description = document.createElement('div');
+          description.setAttribute('class', 'flex');
+          description.appendChild(document.createTextNode(
+              self.computeTitleForContentCategory(category)));
+          var setting = document.createElement('div');
+          setting.setAttribute('class', 'option-value');
 
-    setting.appendChild(document.createTextNode(
-        this.computeCategoryDesc(
-            category, this.isCategoryAllowed(category), false)));
+          setting.appendChild(document.createTextNode(
+              self.computeCategoryDesc(category, enabled, false)));
 
-    paperIcon.appendChild(ironIcon);
-    paperIcon.appendChild(description);
-    paperIcon.appendChild(setting);
-    root.appendChild(paperIcon);
+          paperIcon.appendChild(ironIcon);
+          paperIcon.appendChild(description);
+          paperIcon.appendChild(setting);
+          root.appendChild(paperIcon);
+        });
   },
 
   /**
    * Handles selection of a single category and navigates to the details for
    * that category.
    */
   onTapCategory: function(event) {
     var description = event.currentTarget.querySelector('.flex').innerText;
     this.categorySelected = this.computeCategoryTextId(
         this.computeCategoryFromDesc(description));
     this.currentRoute = {
       page: this.currentRoute.page,
       section: 'privacy',
       subpage: ['site-settings', 'site-settings-category-' +
           this.categorySelected],
     };
   },
 });