Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(121)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1698063002: [test] Clean up a couple TODOs. (Closed)

Created:
4 years, 10 months ago by titzer
Modified:
4 years, 10 months ago
Reviewers:
Benedikt Meurer
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[test] Clean up a couple TODOs. R=bmeurer@chromium.org BUG= Committed: https://crrev.com/232b97dd108e80d4657c0574bfdd157a81b63f97 Cr-Commit-Position: refs/heads/master@{#33990}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -15 lines) Patch
M src/arm64/macro-assembler-arm64.h View 1 chunk +0 lines, -1 line 0 comments Download
M src/compiler/instruction.h View 1 chunk +0 lines, -1 line 0 comments Download
M test/cctest/compiler/test-js-typed-lowering.cc View 3 chunks +10 lines, -13 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
titzer
4 years, 10 months ago (2016-02-15 10:45:17 UTC) #1
Benedikt Meurer
LGTM
4 years, 10 months ago (2016-02-15 10:47:52 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1698063002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1698063002/1
4 years, 10 months ago (2016-02-15 10:55:55 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 10 months ago (2016-02-15 11:18:23 UTC) #5
commit-bot: I haz the power
4 years, 10 months ago (2016-02-15 11:18:53 UTC) #7
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/232b97dd108e80d4657c0574bfdd157a81b63f97
Cr-Commit-Position: refs/heads/master@{#33990}

Powered by Google App Engine
This is Rietveld 408576698