chrome/android/java/res/values/dimens.xml - Issue 1698043006: Created the dialog offering the user to merge their account data or keep it

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/java/res/values/dimens.xml

Issue 1698043006: Created the dialog offering the user to merge their account data or keep it (Closed) Base URL: maybelle.lon.corp.google.com:/usr/local/google/code/clankium/src@sync_settings

Patch Set: Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/android/java/res/values/colors.xml ('k') | chrome/android/java/src/org/chromium/chrome/browser/firstrun/AccountFirstRunFragment.java » ('j') | chrome/android/java/src/org/chromium/chrome/browser/firstrun/AccountFirstRunFragment.java » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/java/res/values/dimens.xml

diff --git a/chrome/android/java/res/values/dimens.xml b/chrome/android/java/res/values/dimens.xml

index 895151e08f6f770ec72ed02771a2dda909b60437..b0f01b1620ee5e43e64e21ef5752d85ead32d3d4 100644

--- a/chrome/android/java/res/values/dimens.xml

+++ b/chrome/android/java/res/values/dimens.xml

@@ -173,6 +173,14 @@

+

+ <dimen name="signin_button_padding">12dp</dimen>

Yusuf 2016/02/22 19:40:09 just curious, are the fre_ dimensions still used?

PEConn 2016/02/23 15:01:53 Yeah, they are all used. I should have a CL in ho

+ <dimen name="signin_margin">24dp</dimen>

+ <dimen name="signin_title_text_size">24sp</dimen>

+ <dimen name="signin_normal_text_size">14sp</dimen>

+ <dimen name="signin_image_carousel_width">260dp</dimen>

+ <dimen name="signin_image_carousel_height">130dp</dimen>