Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2739)

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/signin/SigninPromoScreen.java

Issue 1698043006: Created the dialog offering the user to merge their account data or keep it (Closed) Base URL: maybelle.lon.corp.google.com:/usr/local/google/code/clankium/src@sync_settings
Patch Set: Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/android/java/src/org/chromium/chrome/browser/signin/SigninPromoScreen.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/signin/SigninPromoScreen.java b/chrome/android/java/src/org/chromium/chrome/browser/signin/SigninPromoScreen.java
index b72e67253a8347994ba746c247a9b47ba37ea4ed..4b06d88374e3d5079ffcc3979b326c17be35879c 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/signin/SigninPromoScreen.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/signin/SigninPromoScreen.java
@@ -14,7 +14,6 @@ import android.widget.LinearLayout;
import org.chromium.base.metrics.RecordUserAction;
import org.chromium.chrome.R;
-import org.chromium.chrome.browser.firstrun.AccountFirstRunView;
import org.chromium.chrome.browser.firstrun.ProfileDataCache;
import org.chromium.chrome.browser.multiwindow.MultiWindowUtils;
import org.chromium.chrome.browser.preferences.ChromePreferenceManager;
@@ -24,6 +23,8 @@ import org.chromium.chrome.browser.preferences.PreferencesLauncher;
import org.chromium.chrome.browser.profiles.Profile;
import org.chromium.chrome.browser.signin.SigninManager.SignInCallback;
import org.chromium.chrome.browser.sync.ProfileSyncService;
+import org.chromium.chrome.browser.sync.ui.ConfirmImportSyncDataFragment;
+import org.chromium.chrome.browser.sync.ui.ConfirmImportSyncDataFragment.Listener;
import org.chromium.chrome.browser.sync.ui.SyncCustomizationFragment;
import org.chromium.chrome.browser.widget.AlwaysDismissedDialog;
import org.chromium.sync.signin.ChromeSigninController;
@@ -32,8 +33,8 @@ import org.chromium.sync.signin.ChromeSigninController;
* This class implements the dialog UI for the signin promo.
*/
public class SigninPromoScreen
- extends AlwaysDismissedDialog implements AccountFirstRunView.Listener {
- private AccountFirstRunView mAccountFirstRunView;
+ extends AlwaysDismissedDialog implements AccountSigninView.Listener {
+ private AccountSigninView mAccountFirstRunView;
private ProfileDataCache mProfileDataCache;
private String mAccountName;
@@ -75,9 +76,9 @@ public class SigninPromoScreen
setOwnerActivity(activity);
LayoutInflater inflater = LayoutInflater.from(activity);
- View view = inflater.inflate(R.layout.fre_choose_account, null);
+ View view = inflater.inflate(R.layout.account_signin_view, null);
mProfileDataCache = new ProfileDataCache(activity, Profile.getLastUsedProfile());
- mAccountFirstRunView = (AccountFirstRunView) view.findViewById(R.id.fre_account_layout);
+ mAccountFirstRunView = (AccountSigninView) view.findViewById(R.id.account_layout);
mAccountFirstRunView.init(mProfileDataCache);
mAccountFirstRunView.configureForAddAccountPromo();
mAccountFirstRunView.setListener(this);
@@ -119,7 +120,7 @@ public class SigninPromoScreen
public void onDoneClicked() {
Activity activity = getOwnerActivity();
RecordUserAction.record("Signin_Signin_FromSigninPromo");
- SigninManager.get(activity).signIn(mAccountName, activity, new SignInCallback() {
+ SigninManager.get(activity).signIn(mAccountName, null, new SignInCallback() {
@Override
public void onSignInComplete() {
SigninManager.get(getOwnerActivity()).logInSignedInUser();
@@ -153,4 +154,12 @@ public class SigninPromoScreen
public void onFailedToSetForcedAccount(String forcedAccountName) {
assert false : "No forced accounts in SigninPromoScreen";
}
+
+ @Override
+ public void onPreviousAccountFound(
+ String oldAccountName, String newAccountName, Listener callback) {
+
+ ConfirmImportSyncDataFragment.showNewInstance(
+ oldAccountName, newAccountName, getOwnerActivity().getFragmentManager(), callback);
+ }
}

Powered by Google App Engine
This is Rietveld 408576698