chrome/android/java/src/org/chromium/chrome/browser/bookmarks/BookmarkSigninActivity.java - Issue 1698043006: Created the dialog offering the user to merge their account data or keep it

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/bookmarks/BookmarkSigninActivity.java

Issue 1698043006: Created the dialog offering the user to merge their account data or keep it (Closed) Base URL: maybelle.lon.corp.google.com:/usr/local/google/code/clankium/src@sync_settings

Patch Set: Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/android/java/res/values/dimens.xml ('K') | « chrome/android/java/res/values/dimens.xml ('k') | chrome/android/java/src/org/chromium/chrome/browser/firstrun/AccountFirstRunFragment.java » ('j') | chrome/android/java/src/org/chromium/chrome/browser/firstrun/AccountFirstRunFragment.java » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/java/src/org/chromium/chrome/browser/bookmarks/BookmarkSigninActivity.java

diff --git a/chrome/android/java/src/org/chromium/chrome/browser/bookmarks/BookmarkSigninActivity.java b/chrome/android/java/src/org/chromium/chrome/browser/bookmarks/BookmarkSigninActivity.java

index dedbb5c650dba319765ecd0c6916c312e6f678aa..e84fcd7bdd27f145444b9017a18a29853af2c95e 100644

--- a/chrome/android/java/src/org/chromium/chrome/browser/bookmarks/BookmarkSigninActivity.java

+++ b/chrome/android/java/src/org/chromium/chrome/browser/bookmarks/BookmarkSigninActivity.java

@@ -127,7 +127,6 @@ public class BookmarkSigninActivity extends BookmarkActivityBase implements

@Override

public void onNewAccount() {

RecordUserAction.record("Stars_SignInPromoActivity_NewAccount");

- RecordUserAction.record("Signin_AddAccountToDevice");

newt (away) 2016/02/25 06:25:53 why remove this?

PEConn 2016/02/25 14:19:51 At the request of gogerald@ .

}

@Override