chrome/android/java/res/layout/radio_button_with_description.xml - Issue 1698043006: Created the dialog offering the user to merge their account data or keep it

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/android/java/res/layout/radio_button_with_description.xml

Issue 1698043006: Created the dialog offering the user to merge their account data or keep it (Closed) Base URL: maybelle.lon.corp.google.com:/usr/local/google/code/clankium/src@sync_settings

Patch Set: Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« chrome/android/java/res/layout/confirm_import_sync_data.xml ('K') | « chrome/android/java/res/layout/fre_choose_account.xml ('k') | chrome/android/java/res/values/attrs.xml » ('j') | chrome/android/java/res/values/attrs.xml » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 <?xml version="1.0" encoding="utf-8"?>

	2 <!-- Copyright 2016 The Chromium Authors. All rights reserved.

	3 Use of this source code is governed by a BSD-style license that can be

	4 found in the LICENSE file. -->

	5

	6 <!-- RadioButtonWithDescription extends LinearLayout -->

	7 <merge xmlns:android="http://schemas.android.com/apk/res/android"
	newt (away) 2016/02/25 06:25:52 A RelativeLayout would be better here to reduce la A RelativeLayout would be better here to reduce layout nesting (then you can remove the inner LinearLayout) PEConn 2016/02/25 14:19:51 Done. Show quoted text On 2016/02/25 06:25:52, newt wrote: > A RelativeLayout would be better here to reduce layout nesting (then you can > remove the inner LinearLayout) Done.
	8 android:orientation="horizontal"

	9 android:paddingTop="10dp" >

	10

	11 <RadioButton

	12 android:id="@+id/radio_button"

	13 android:layout_width="wrap_content"

	14 android:layout_height="wrap_content"

	15 android:layout_gravity="center_horizontal"
	newt (away) 2016/02/25 06:25:52 does this do anything? does this do anything? PEConn 2016/02/25 14:19:51 Done. Show quoted text On 2016/02/25 06:25:52, newt wrote: > does this do anything? Done.
	16 android:paddingEnd="16dp" />

	17

	18 <LinearLayout

	19 android:orientation="vertical"

	20 android:layout_width="match_parent"

	21 android:layout_height="wrap_content">

	22

	23 <TextView

	24 android:id="@+id/title"

	25 android:layout_width="wrap_content"

	26 android:layout_height="wrap_content"

	27 android:fontFamily="sans-serif"
	newt (away) 2016/02/25 06:25:52 not needed. same below. sans-serif is the default not needed. same below. sans-serif is the default font value. PEConn 2016/02/25 14:19:51 Done. Show quoted text On 2016/02/25 06:25:52, newt wrote: > not needed. same below. sans-serif is the default font value. Done.
	28 android:textColor="#de000000"

	29 android:textSize="16sp" />

	30

	31 <TextView

	32 android:id="@+id/description"

	33 android:layout_width="wrap_content"

	34 android:layout_height="wrap_content"

	35 android:fontFamily="sans-serif"

	36 android:textColor="#8a000000"

	37 android:textSize="14sp" />

	38 </LinearLayout>

	39 </merge>

OLD	NEW