Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(170)

Issue 169803003: Adding typing detection to the APM in chrome. (Closed)

Created:
6 years, 10 months ago by no longer working on chromium
Modified:
6 years, 10 months ago
Reviewers:
Henrik Grunell
CC:
chromium-reviews, fischman+watch_chromium.org, jam, mcasas+watch_chromium.org, joi+watch-content_chromium.org, feature-media-reviews_chromium.org, darin-cc_chromium.org, wjia+watch_chromium.org
Base URL:
http://git.chromium.org/chromium/src.git@master
Visibility:
Public.

Description

Adding typing detection to the APM in chrome. BUG=264611 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=252334

Patch Set 1 #

Total comments: 7

Patch Set 2 : addressed the comments. #

Total comments: 4

Patch Set 3 : move the typing detector to EnableTypingDetection() #

Unified diffs Side-by-side diffs Delta from patch set Stats (+35 lines, -6 lines) Patch
M content/renderer/media/media_stream_audio_processor.h View 1 2 chunks +7 lines, -0 lines 0 comments Download
M content/renderer/media/media_stream_audio_processor.cc View 1 2 5 chunks +19 lines, -4 lines 0 comments Download
M content/renderer/media/media_stream_audio_processor_options.h View 1 2 2 chunks +3 lines, -1 line 0 comments Download
M content/renderer/media/media_stream_audio_processor_options.cc View 1 2 2 chunks +6 lines, -1 line 0 comments Download

Messages

Total messages: 10 (0 generated)
no longer working on chromium
Henrik, could you please review? This CL should do what your CL http://review.webrtc.org/6219004/ does in ...
6 years, 10 months ago (2014-02-17 16:09:11 UTC) #1
Henrik Grunell
https://codereview.chromium.org/169803003/diff/1/content/renderer/media/media_stream_audio_processor.cc File content/renderer/media/media_stream_audio_processor.cc (right): https://codereview.chromium.org/169803003/diff/1/content/renderer/media/media_stream_audio_processor.cc#newcode270 content/renderer/media/media_stream_audio_processor.cc:270: !audio_mirroring_) { I assume this doesn't have to do ...
6 years, 10 months ago (2014-02-18 09:24:06 UTC) #2
Henrik Grunell
https://codereview.chromium.org/169803003/diff/1/content/renderer/media/media_stream_audio_processor.cc File content/renderer/media/media_stream_audio_processor.cc (right): https://codereview.chromium.org/169803003/diff/1/content/renderer/media/media_stream_audio_processor.cc#newcode291 content/renderer/media/media_stream_audio_processor.cc:291: EnableTypingDetection(audio_processing_.get()); On 2014/02/18 09:24:06, Henrik Grunell wrote: > As ...
6 years, 10 months ago (2014-02-18 09:34:13 UTC) #3
no longer working on chromium
Hi Henrik, PTAL. Thanks SX https://codereview.chromium.org/169803003/diff/1/content/renderer/media/media_stream_audio_processor.cc File content/renderer/media/media_stream_audio_processor.cc (right): https://codereview.chromium.org/169803003/diff/1/content/renderer/media/media_stream_audio_processor.cc#newcode270 content/renderer/media/media_stream_audio_processor.cc:270: !audio_mirroring_) { On 2014/02/18 ...
6 years, 10 months ago (2014-02-18 17:47:09 UTC) #4
Henrik Grunell
https://codereview.chromium.org/169803003/diff/70001/content/renderer/media/media_stream_audio_processor.cc File content/renderer/media/media_stream_audio_processor.cc (right): https://codereview.chromium.org/169803003/diff/70001/content/renderer/media/media_stream_audio_processor.cc#newcode291 content/renderer/media/media_stream_audio_processor.cc:291: EnableTypingDetection(audio_processing_.get()); The semantics/naming is a bit unclear. EnableTypingDetection() doesn't ...
6 years, 10 months ago (2014-02-19 06:54:42 UTC) #5
no longer working on chromium
Henrik, PTAL. Thanks, SX https://codereview.chromium.org/169803003/diff/70001/content/renderer/media/media_stream_audio_processor.cc File content/renderer/media/media_stream_audio_processor.cc (right): https://codereview.chromium.org/169803003/diff/70001/content/renderer/media/media_stream_audio_processor.cc#newcode291 content/renderer/media/media_stream_audio_processor.cc:291: EnableTypingDetection(audio_processing_.get()); On 2014/02/19 06:54:42, Henrik ...
6 years, 10 months ago (2014-02-20 12:44:13 UTC) #6
Henrik Grunell
lgtm
6 years, 10 months ago (2014-02-20 14:18:55 UTC) #7
no longer working on chromium
The CQ bit was checked by xians@chromium.org
6 years, 10 months ago (2014-02-20 14:25:15 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/xians@chromium.org/169803003/130001
6 years, 10 months ago (2014-02-20 14:25:25 UTC) #9
commit-bot: I haz the power
6 years, 10 months ago (2014-02-20 18:49:02 UTC) #10
Message was sent while issue was closed.
Change committed as 252334

Powered by Google App Engine
This is Rietveld 408576698