Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(554)

Issue 1698001: Receive cacheable metadata from the renderer and... (Closed)

Created:
10 years, 8 months ago by tonyg
Modified:
9 years, 6 months ago
CC:
chromium-reviews, jam+cc_chromium.org, ben+cc_chromium.org, darin-cc_chromium.org, brettw-cc_chromium.org
Visibility:
Public.

Description

Wire sending/receiving cacheable metadata from the renderer to the disk cache. BUG=32407 TEST=None Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=47522

Patch Set 1 #

Patch Set 2 : '' #

Patch Set 3 : '' #

Patch Set 4 : '' #

Patch Set 5 : '' #

Patch Set 6 : '' #

Patch Set 7 : '' #

Patch Set 8 : '' #

Total comments: 3

Patch Set 9 : '' #

Patch Set 10 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+114 lines, -3 lines) Patch
M chrome/browser/renderer_host/async_resource_handler.cc View 6 7 8 9 1 chunk +9 lines, -0 lines 0 comments Download
M chrome/browser/renderer_host/resource_message_filter.h View 1 2 3 4 5 6 7 8 9 2 chunks +5 lines, -2 lines 0 comments Download
M chrome/browser/renderer_host/resource_message_filter.cc View 1 2 3 4 5 6 7 8 9 3 chunks +31 lines, -1 line 0 comments Download
M chrome/common/chrome_switches.h View 5 6 7 8 9 1 chunk +1 line, -0 lines 0 comments Download
M chrome/common/chrome_switches.cc View 5 6 7 8 9 1 chunk +3 lines, -0 lines 0 comments Download
M chrome/common/render_messages_internal.h View 1 2 3 4 5 6 7 8 9 2 chunks +12 lines, -0 lines 0 comments Download
M chrome/common/resource_dispatcher.h View 6 7 8 9 1 chunk +1 line, -0 lines 0 comments Download
M chrome/common/resource_dispatcher.cc View 6 7 8 9 3 chunks +21 lines, -0 lines 0 comments Download
M chrome/renderer/renderer_webkitclient_impl.h View 4 5 6 7 8 9 2 chunks +4 lines, -0 lines 0 comments Download
M chrome/renderer/renderer_webkitclient_impl.cc View 4 5 6 7 8 9 1 chunk +27 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
tonyg
10 years, 7 months ago (2010-05-17 17:22:03 UTC) #1
rvargas (doing something else)
nice. http://codereview.chromium.org/1698001/diff/49008/48012 File chrome/browser/renderer_host/resource_message_filter.cc (right): http://codereview.chromium.org/1698001/diff/49008/48012#newcode1348 chrome/browser/renderer_host/resource_message_filter.cc:1348: url, base::Time::FromDoubleT(expected_response_time), buf, data.size()); Don't we want to ...
10 years, 7 months ago (2010-05-17 23:22:18 UTC) #2
tonyg
On 2010/05/17 23:22:18, rvargas wrote: > nice. > > http://codereview.chromium.org/1698001/diff/49008/48012 > File chrome/browser/renderer_host/resource_message_filter.cc (right): > ...
10 years, 7 months ago (2010-05-18 00:42:48 UTC) #3
rvargas (doing something else)
10 years, 7 months ago (2010-05-18 00:57:27 UTC) #4
LGTM

Powered by Google App Engine
This is Rietveld 408576698