Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(887)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1697973002: Devtools: Fix crash when inspecting keyframes injected via CSSOM (Closed)

Created:
4 years, 10 months ago by samli
Modified:
4 years, 10 months ago
Reviewers:
pfeldman
CC:
apavlov+blink_chromium.org, blink-reviews, blink-reviews-style_chromium.org, caseq+blink_chromium.org, chromium-reviews, devtools-reviews_chromium.org, kozyatinskiy+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, sergeyv+blink_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Devtools: Fix crash when inspecting keyframes injected via CSSOM Keyframe rules injected via CSSOM have no associated source range. BUG=586085 Committed: https://crrev.com/965aad97d3fb18f575ee27371ae2917caada250c Cr-Commit-Position: refs/heads/master@{#376102}

Patch Set 1 : #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+35 lines, -2 lines) Patch
A third_party/WebKit/LayoutTests/inspector/elements/styles-4/styles-keyframes-cssom-injected.html View 1 chunk +29 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/inspector/elements/styles-4/styles-keyframes-cssom-injected-expected.txt View 1 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/core/inspector/InspectorCSSAgent.cpp View 1 chunk +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/inspector/InspectorStyleSheet.cpp View 1 chunk +3 lines, -1 line 0 comments Download

Messages

Total messages: 22 (11 generated)
samli
4 years, 10 months ago (2016-02-15 04:26:08 UTC) #3
pfeldman
lgtm
4 years, 10 months ago (2016-02-17 01:11:18 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1697973002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1697973002/20001
4 years, 10 months ago (2016-02-17 02:49:34 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_ng/builds/181008)
4 years, 10 months ago (2016-02-17 04:06:12 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1697973002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1697973002/20001
4 years, 10 months ago (2016-02-17 05:57:48 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_ng/builds/181077)
4 years, 10 months ago (2016-02-17 07:14:15 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1697973002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1697973002/40001
4 years, 10 months ago (2016-02-18 00:27:55 UTC) #15
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_rel_ng on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_ng/builds/175338)
4 years, 10 months ago (2016-02-18 00:43:04 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1697973002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1697973002/40001
4 years, 10 months ago (2016-02-18 05:38:42 UTC) #19
commit-bot: I haz the power
Committed patchset #2 (id:40001)
4 years, 10 months ago (2016-02-18 05:43:52 UTC) #20
commit-bot: I haz the power
4 years, 10 months ago (2016-02-18 05:45:16 UTC) #22
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/965aad97d3fb18f575ee27371ae2917caada250c
Cr-Commit-Position: refs/heads/master@{#376102}

Powered by Google App Engine
This is Rietveld 408576698