Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(548)

Unified Diff: src/processor/exploitability_linux.h

Issue 1697963002: Fixing a flaky Linux exploitability unittest. (Closed) Base URL: https://chromium.googlesource.com/breakpad/breakpad.git@master
Patch Set: Fixing a typo. Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | src/processor/exploitability_linux.cc » ('j') | src/processor/exploitability_linux.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/processor/exploitability_linux.h
diff --git a/src/processor/exploitability_linux.h b/src/processor/exploitability_linux.h
index 93c5082fb3c26398cacbd17c1c8a65bf667579e1..e3ff13b6e07da325316639bf55739432c01381b1 100644
--- a/src/processor/exploitability_linux.h
+++ b/src/processor/exploitability_linux.h
@@ -86,6 +86,13 @@ class ExploitabilityLinux : public Exploitability {
const unsigned int MAX_OBJDUMP_BUFFER_LEN,
char *objdump_output_buffer);
+ // Parses the objdump output given in |objdump_output_buffer| and extracts
+ // the line of the first instruction into |instruction_line|. Returns true
+ // when the instruction line is successfully extracted.
+ static bool GetObjdumpInstructionLine(
+ const char *objdump_output_buffer,
+ string *instruction_line);
+
// Tokenizes out the operation and operands from a line of instruction
// disassembled by objdump. This method modifies the pointers to match the
// tokens of the instruction, and returns if the tokenizing was a success.
« no previous file with comments | « no previous file | src/processor/exploitability_linux.cc » ('j') | src/processor/exploitability_linux.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698