Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(112)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1697953002: X87: [turbofan] Add TruncateFloat32ToUint32 operator to Turbofan. (Closed)

Created:
4 years, 10 months ago by zhengxing.li
Modified:
4 years, 10 months ago
Reviewers:
Weiliang, chunyang.dai, Jing
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

X87: [turbofan] Add TruncateFloat32ToUint32 operator to Turbofan. port 2166bd8ce51f83693fa88f590b82d24a1856e0e7 (r33797) original commit message: BUG= Committed: https://crrev.com/7c37571c390e335ccb25e23b012ee9a9544e56de Cr-Commit-Position: refs/heads/master@{#33969}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+23 lines, -1 line) Patch
M src/compiler/x87/code-generator-x87.cc View 1 chunk +20 lines, -0 lines 0 comments Download
M src/compiler/x87/instruction-codes-x87.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/compiler/x87/instruction-selector-x87.cc View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 8 (3 generated)
zhengxing.li
PTAL, thanks!
4 years, 10 months ago (2016-02-15 02:52:36 UTC) #2
Weiliang
lgtm
4 years, 10 months ago (2016-02-15 06:13:28 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1697953002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1697953002/1
4 years, 10 months ago (2016-02-15 06:15:52 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 10 months ago (2016-02-15 06:36:32 UTC) #6
commit-bot: I haz the power
4 years, 10 months ago (2016-02-15 06:37:09 UTC) #8
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/7c37571c390e335ccb25e23b012ee9a9544e56de
Cr-Commit-Position: refs/heads/master@{#33969}

Powered by Google App Engine
This is Rietveld 408576698