chrome/browser/chromeos/login/language_switch_menu.cc - Issue 16979002: Add ContextMenuSourceType to views::ContextMenuController::ShowContextMenuForView.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/chromeos/login/language_switch_menu.cc

Issue 16979002: Add ContextMenuSourceType to views::ContextMenuController::ShowContextMenuForView. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: fix win build Created 7 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« ash/system/web_notification/web_notification_tray.cc ('K') | « ash/system/web_notification/web_notification_tray.cc ('k') | chrome/browser/ui/views/action_box_context_menu.h » ('j') | chrome/browser/ui/views/autofill/autofill_dialog_views.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/chromeos/login/language_switch_menu.cc

diff --git a/chrome/browser/chromeos/login/language_switch_menu.cc b/chrome/browser/chromeos/login/language_switch_menu.cc

index d4b73c2a5dc21a19431dad5549eae5025ea816ec..d4dab0f480a0dc8926b60f250e2db92ef570eb4c 100644

--- a/chrome/browser/chromeos/login/language_switch_menu.cc

+++ b/chrome/browser/chromeos/login/language_switch_menu.cc

@@ -184,7 +184,8 @@ void LanguageSwitchMenu::OnMenuButtonClicked(views::View* source,

if (menu_runner_->RunMenuAt(button->GetWidget(), button,

gfx::Rect(new_pt, gfx::Size()), views::MenuItemView::TOPLEFT,

- views::MenuRunner::HAS_MNEMONICS) == views::MenuRunner::MENU_DELETED)

+ ui::MENU_SOURCE_NONE, views::MenuRunner::HAS_MNEMONICS) ==

sky 2013/06/17 16:08:19 Why the none here?

varunjain 2013/06/17 20:13:55 This is one of the instances that cannot be fixed

+ views::MenuRunner::MENU_DELETED)

return;

}