third_party/WebKit/LayoutTests/bluetooth/getCharacteristic-blacklist.html - Issue 1697873002: bluetooth: Test Web Bluetooth getCharacteristic calls against blacklist.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/LayoutTests/bluetooth/getCharacteristic-blacklist.html

Issue 1697873002: bluetooth: Test Web Bluetooth getCharacteristic calls against blacklist. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@bt-blacklist-integration-

Patch Set: addressed ortuno's comments Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« content/shell/browser/layout_test/layout_test_bluetooth_adapter_provider.cc ('K') | « content/shell/browser/layout_test/layout_test_bluetooth_adapter_provider.cc ('k') | third_party/WebKit/Source/modules/bluetooth/BluetoothError.cpp » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 <!DOCTYPE html>

	2 <script src="../resources/testharness.js"></script>

	3 <script src="../resources/testharnessreport.js"></script>

	4 <script src="resources/bluetooth-helpers.js"></script>

	5 <script>

	6 'use strict';

	7

	8 test(t => { assert_true(window.testRunner instanceof Object); t.done(); },

	9 'window.testRunner is required for the following tests.');

	10

	11 promise_test(() => {

	12 testRunner.setBluetoothMockDataSet('HeartRateAndHIDAdapter');

	13 return requestDeviceWithKeyDown(

	14 {

	15 filters: [{services: ['heart_rate']}],

	16 optionalServices: ['device_information', 'human_interface_device']
	ortuno 2016/02/24 23:08:17 I think you can get away with requesting only devi I think you can get away with requesting only device_information. I don't think you use the other ones. scheib 2016/02/24 23:38:52 Done. Show quoted text On 2016/02/24 23:08:17, ortuno wrote: > I think you can get away with requesting only device_information. I don't think > you use the other ones. Done.
	17 })

	18 .then(device => device.gatt.connect())

	19 .then(gattServer => gattServer.getPrimaryService('device_information'))

	20 .then(service => {

	21 return assert_promise_rejects_with_message(

	22 service.getCharacteristic('serial_number_string'),

	23 new DOMException('getCharacteristic(s) called with blacklisted UUID. ' +

	24 'https://goo.gl/4NeimX',
	ortuno 2016/02/24 23:08:17 nit: I think the "'"s in these two lines should li nit: I think the "'"s in these two lines should line up. scheib 2016/02/24 23:38:52 Done. Show quoted text On 2016/02/24 23:08:17, ortuno wrote: > nit: I think the "'"s in these two lines should line up. Done.
	25 'SecurityError'),

	26 'Serial Number String characteristic is blacklisted.');

	27 });

	28 }, 'Serial Number String characteristic is blacklisted.');

	29 </script>

OLD	NEW