Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(460)

Issue 1697863004: perf: Remove redirect from mobile site (Closed)

Created:
4 years, 10 months ago by Sami (do not use)
Modified:
4 years, 10 months ago
Reviewers:
Sami, petrcermak
CC:
chromium-reviews, telemetry-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

perf: Remove redirect from mobile site Remove redirect from the Google Search mobile site because telemetry can't currently correctly pick up interaction records that are emitted via javascript and where a redirect happened during the interaction. BUG=540022, 586156

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M tools/perf/page_sets/data/key_mobile_sites.json View 1 chunk +1 line, -1 line 0 comments Download
M tools/perf/page_sets/key_mobile_sites.py View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 10 (5 generated)
Sami
4 years, 10 months ago (2016-02-15 18:11:08 UTC) #4
petrcermak
LGTM. Thanks, Petr
4 years, 10 months ago (2016-02-15 18:12:08 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1697863004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1697863004/1
4 years, 10 months ago (2016-02-15 18:12:47 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/146171)
4 years, 10 months ago (2016-02-15 18:21:15 UTC) #9
Sami
4 years, 10 months ago (2016-02-15 18:27:28 UTC) #10
D'oh, wrong account -- reuploaded to https://codereview.chromium.org/1702463002/

Powered by Google App Engine
This is Rietveld 408576698