Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(27)

Issue 169783002: Harmony: implement Math.clz32 (Closed)

Created:
6 years, 10 months ago by Yang
Modified:
6 years, 10 months ago
CC:
v8-dev
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : actually upload files #

Patch Set 3 : reformat test file. #

Patch Set 4 : renamed to Math.clz32 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+45 lines, -1 line) Patch
M src/harmony-math.js View 1 2 3 2 chunks +17 lines, -1 line 1 comment Download
A test/mjsunit/harmony/math-clz32.js View 1 2 3 1 chunk +28 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
Yang
6 years, 10 months ago (2014-02-17 15:38:59 UTC) #1
Yang
6 years, 10 months ago (2014-02-17 15:39:00 UTC) #2
Yang
6 years, 10 months ago (2014-02-17 15:39:01 UTC) #3
Yang
6 years, 10 months ago (2014-02-17 15:39:02 UTC) #4
Dmitry Lomov (no reviews)
lgtm
6 years, 10 months ago (2014-02-17 16:01:40 UTC) #5
Sven Panne
LGTM as a first step, too, but I think this should have Crankshaft support. https://codereview.chromium.org/169783002/diff/130001/src/harmony-math.js ...
6 years, 10 months ago (2014-02-18 07:21:24 UTC) #6
Yang
On 2014/02/18 07:21:24, Sven Panne wrote: > LGTM as a first step, too, but I ...
6 years, 10 months ago (2014-02-18 07:27:21 UTC) #7
Sven Panne
Math.imul, Math.clz32, ... What will be next? :)
6 years, 10 months ago (2014-02-18 07:28:20 UTC) #8
Yang
6 years, 10 months ago (2014-02-18 10:49:41 UTC) #9
Message was sent while issue was closed.
Committed patchset #4 manually as r19435 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698