build/landmines.py - Issue 16978002: Fix Landmines MSVS Version Checking

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: build/landmines.py

Issue 16978002: Fix Landmines MSVS Version Checking (Closed) Base URL: https://src.chromium.org/chrome/trunk/src/

Patch Set: Created 7 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: build/landmines.py

===================================================================

--- build/landmines.py (revision 206100)

+++ build/landmines.py (working copy)

@@ -69,7 +69,7 @@

@memoize()

def gyp_msvs_version():

val = os.environ.get('GYP_MSVS_VERSION', '')

- return int(val) if val else None

+ return val if val else None

iannucci 2013/06/13 18:12:44 Actually, you can just make this return os.enviro

robliao 2013/06/13 18:27:31 Done.

@memoize()

def distributor():

@@ -154,7 +154,7 @@

if platform() == 'mac':

add('Switching from bundle to unbundled dylib (issue 14743002).')

if (platform() == 'win' and builder() == 'ninja' and

- gyp_msvs_version() == 2012 and

+ gyp_msvs_version() == '2012' and

gyp_defines().get('target_arch') == 'x64' and

gyp_defines().get('dcheck_always_on') == '1'):

add("Switched win x64 trybots from VS2010 to VS2012.")

« no previous file with comments | « no previous file | no next file » | no next file with comments »