Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(317)

Issue 169773002: Create HandleScope before calling GetScriptLineNumber (Closed)

Created:
6 years, 10 months ago by yurys
Modified:
6 years, 10 months ago
CC:
v8-dev
Visibility:
Public.

Description

Create HandleScope before calling GetScriptLineNumber Otherwise we may crash. BUG=None LOG=N R=alph@chromium.org, hpayer@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=19437

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M src/allocation-tracker.cc View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
yurys
6 years, 10 months ago (2014-02-17 15:39:32 UTC) #1
alph
lgtm
6 years, 10 months ago (2014-02-17 15:49:31 UTC) #2
yurys
@hpayer: please do OWNER review
6 years, 10 months ago (2014-02-18 08:04:37 UTC) #3
Hannes Payer (out of office)
lgtm
6 years, 10 months ago (2014-02-18 09:39:55 UTC) #4
yurys
6 years, 10 months ago (2014-02-18 11:30:51 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 manually as r19437 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698