Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(568)

Issue 1697723002: Add command line flags to dump asm.js -> wasm conversion data. (Closed)

Created:
4 years, 10 months ago by bradnelson
Modified:
4 years, 10 months ago
Reviewers:
titzer, aseemgarg, bradn
CC:
v8-reviews_googlegroups.com, Michael Hablich
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Add command line flags to dump asm.js -> wasm conversion data. BUG= https://code.google.com/p/v8/issues/detail?id=4203 TEST=manual R=titzer@chromium.org,aseemgarg@chromium.org LOG=N Committed: https://crrev.com/a26d0ac676ffc96a886e294728e69f5e7ba11b25 Cr-Commit-Position: refs/heads/master@{#34009}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -0 lines) Patch
M src/flag-definitions.h View 1 chunk +4 lines, -0 lines 0 comments Download
M src/wasm/wasm-js.cc View 1 chunk +9 lines, -0 lines 0 comments Download

Messages

Total messages: 15 (4 generated)
bradn
4 years, 10 months ago (2016-02-13 00:59:00 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1697723002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1697723002/1
4 years, 10 months ago (2016-02-13 00:59:07 UTC) #3
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 10 months ago (2016-02-13 01:20:29 UTC) #5
aseemgarg
lgtm Even though this will only be used for debugging, still multiple processes can potentially ...
4 years, 10 months ago (2016-02-13 01:54:25 UTC) #6
bradn
Only one thread without SABs turned on :-)
4 years, 10 months ago (2016-02-13 01:55:29 UTC) #7
bradn
Ben, will need an OWNERs lg for flags.
4 years, 10 months ago (2016-02-13 01:55:44 UTC) #8
bradn
Oh yes, multiple processes, hmmn, same is true of v8.log
4 years, 10 months ago (2016-02-13 01:56:12 UTC) #9
titzer
On 2016/02/13 01:56:12, bradn wrote: > Oh yes, multiple processes, hmmn, same is true of ...
4 years, 10 months ago (2016-02-14 11:19:23 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1697723002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1697723002/1
4 years, 10 months ago (2016-02-16 02:25:26 UTC) #12
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 10 months ago (2016-02-16 03:02:58 UTC) #13
commit-bot: I haz the power
4 years, 10 months ago (2016-02-16 03:03:32 UTC) #15
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/a26d0ac676ffc96a886e294728e69f5e7ba11b25
Cr-Commit-Position: refs/heads/master@{#34009}

Powered by Google App Engine
This is Rietveld 408576698