Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(196)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1697713002: [WIP] ImageResourceClient->ImageResourceObserver (Closed)

Created:
4 years, 10 months ago by Nate Chapin
Modified:
4 years, 1 month ago
Reviewers:
hiroshige, yhirano
CC:
chromium-reviews, eae+blinkwatch, fs, apavlov+blink_chromium.org, kouhei+svg_chromium.org, pdr+svgwatchlist_chromium.org, Yoav Weiss, krit, blink-reviews-css, szager+layoutwatch_chromium.org, dglazkov+blink, gavinp+loader_chromium.org, jchaffraix+rendering, blink-reviews, gyuyoung2, rwlbuis, blink-reviews-style_chromium.org, zoltan1, blink-reviews-layout_chromium.org, loading-reviews_chromium.org, darktears, loading-reviews+fetch_chromium.org, tyoshino+watch_chromium.org, pdr+renderingwatchlist_chromium.org, leviw+renderwatch, f(malita), Stephen Chennney
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[WIP] ImageResourceClient->ImageResourceObserver BUG=

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+183 lines, -321 lines) Patch
M third_party/WebKit/Source/core/core.gypi View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/css/CSSCrossfadeValue.h View 3 chunks +2 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/css/CSSCrossfadeValue.cpp View 2 chunks +6 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/core/fetch/ImageResource.h View 3 chunks +9 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/core/fetch/ImageResource.cpp View 5 chunks +30 lines, -37 lines 0 comments Download
D third_party/WebKit/Source/core/fetch/ImageResourceClient.h View 1 chunk +0 lines, -57 lines 0 comments Download
A + third_party/WebKit/Source/core/fetch/ImageResourceObserver.h View 2 chunks +9 lines, -9 lines 0 comments Download
M third_party/WebKit/Source/core/fetch/ImageResourceTest.cpp View 1 chunk +1 line, -2 lines 0 comments Download
M third_party/WebKit/Source/core/fetch/MemoryCacheTest.cpp View 5 chunks +7 lines, -7 lines 0 comments Download
D third_party/WebKit/Source/core/fetch/MockImageResourceClient.h View 1 chunk +0 lines, -67 lines 0 comments Download
D third_party/WebKit/Source/core/fetch/MockImageResourceClient.cpp View 1 chunk +0 lines, -38 lines 0 comments Download
A + third_party/WebKit/Source/core/fetch/MockResourceClients.h View 1 chunk +25 lines, -15 lines 0 comments Download
A + third_party/WebKit/Source/core/fetch/MockResourceClients.cpp View 1 chunk +26 lines, -7 lines 0 comments Download
M third_party/WebKit/Source/core/fetch/RawResourceTest.cpp View 1 chunk +0 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/fetch/Resource.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/fetch/Resource.cpp View 1 chunk +0 lines, -14 lines 0 comments Download
M third_party/WebKit/Source/core/fetch/ResourceClient.h View 2 chunks +0 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/frame/ImageBitmapTest.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutImage.h View 3 chunks +3 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutImage.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutImageResource.h View 2 chunks +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutImageResource.cpp View 3 chunks +16 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutImageResourceStyleImage.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutImageResourceStyleImage.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutObject.h View 5 chunks +7 lines, -7 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutObject.cpp View 3 chunks +3 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/core/layout/svg/LayoutSVGImage.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/loader/ImageLoader.h View 3 chunks +4 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/loader/ImageLoader.cpp View 3 chunks +13 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/core/loader/LinkPreloadResourceClients.h View 3 chunks +2 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/style/StyleFetchedImage.h View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/style/StyleFetchedImage.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/style/StyleFetchedImageSet.h View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/style/StyleFetchedImageSet.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/svg/SVGFEImageElement.h View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 4 (2 generated)
Nate Chapin
FYI. I don't think this actually works yet, but it's a start.
4 years, 10 months ago (2016-02-13 00:51:32 UTC) #3
Nate Chapin
4 years, 10 months ago (2016-02-13 00:51:47 UTC) #4 
On 2016/02/13 00:51:32, Nate Chapin wrote:
> FYI. I don't think this actually works yet, but it's a start.

Feel free to take it and build on it if it's useful :)

Powered by Google App Engine
This is Rietveld 408576698