Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(290)

Unified Diff: sdk/lib/_internal/compiler/implementation/resolution/class_members.dart

Issue 169763003: Update dart2js diagnostics to prepare for filtering. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Remove optional Uri. Created 6 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: sdk/lib/_internal/compiler/implementation/resolution/class_members.dart
diff --git a/sdk/lib/_internal/compiler/implementation/resolution/class_members.dart b/sdk/lib/_internal/compiler/implementation/resolution/class_members.dart
index c8c9c00c489726373bce23177c6d8711753b7c8d..ec17634d4159433f52182aefef012fdb74c9c4fb 100644
--- a/sdk/lib/_internal/compiler/implementation/resolution/class_members.dart
+++ b/sdk/lib/_internal/compiler/implementation/resolution/class_members.dart
@@ -221,9 +221,9 @@ class MembersCreator {
() => new Set<Member>()).add(inherited);
}
if (someAreGetters && !allAreGetters) {
- compiler.reportWarningCode(cls,
- MessageKind.INHERIT_GETTER_AND_METHOD,
- {'class': thisType, 'name': name.text });
+ compiler.reportWarning(cls,
+ MessageKind.INHERIT_GETTER_AND_METHOD,
+ {'class': thisType, 'name': name.text });
for (Member inherited in inheritedMembers) {
MessageKind kind;
if (inherited.isMethod) {
@@ -357,7 +357,7 @@ class MembersCreator {
}
reportMessage(
interfaceMember.element, MessageKind.ABSTRACT_METHOD, () {
- compiler.reportWarningCode(
+ compiler.reportWarning(
interfaceMember.element, kind,
{'class': cls.name, 'name': name.text});
});
@@ -369,7 +369,7 @@ class MembersCreator {
Member inherited = interfaceMember.declarations.first;
reportMessage(
interfaceMember, MessageKind.UNIMPLEMENTED_METHOD, () {
- compiler.reportWarningCode(cls,
+ compiler.reportWarning(cls,
interfaceMember.declarations.length == 1
? singleKind : multipleKind,
{'class': cls.name,
@@ -418,7 +418,7 @@ class MembersCreator {
if (superMember != null && superMember.isStatic) {
reportMessage(superMember, MessageKind.INSTANCE_STATIC_SAME_NAME,
() {
- compiler.reportWarningCode(
+ compiler.reportWarning(
declared.element,
MessageKind.INSTANCE_STATIC_SAME_NAME,
{'memberName': declared.name,
@@ -479,7 +479,7 @@ class MembersCreator {
MessageKind warningKind,
MessageKind infoKind) {
reportMessage(marker, MessageKind.INVALID_OVERRIDE_METHOD, () {
- compiler.reportWarningCode(declared.element, warningKind,
+ compiler.reportWarning(declared.element, warningKind,
{'declaredType': declared.type,
'name': declared.name.text,
'class': cls.thisType,

Powered by Google App Engine
This is Rietveld 408576698