Simplify SVGAnimatedHref

Simplify SVGAnimatedHref

Let SVGAnimatedHref hold the actual value for 'href' and just wrap the
object for 'xlink:href'. This means we can get rid of most of the
overrides.

BUG=584142
Committed: https://crrev.com/31faa6d4fc1e3396c3749b4b8986c7a86bab2240
Cr-Commit-Position: refs/heads/master@{#375861}

[fs, 2016-02-12 19:54:41]

Description was changed from

==========
Simplify SVGAnimatedHref

Let SVGAnimatedHref hold the actual value for 'href' and just wrap the
object for 'xlink:href'. This means we can get rid of most of the
overrides.
==========

to

==========
Simplify SVGAnimatedHref

Let SVGAnimatedHref hold the actual value for 'href' and just wrap the
object for 'xlink:href'. This means we can get rid of most of the
overrides.

BUG=584142
==========

[fs, 2016-02-15 11:33:21]

fs@opera.com changed reviewers:
+ davve@opera.com, pdr@chromium.org

[fs, 2016-02-15 11:33:21]

Figured out yet another way to structure the 'href' vs. 'xlink:href' wrapping.
This way is slightly less "wasteful" (no need for overrides for asserts and no
"unused" wrapper object; less LoC), but it's possibly a bit more fragile
(although the ways to screw up are approximately the same.)

What do you think?

[davve, 2016-02-15 16:17:27]

I like it. I was admittedly a bit confused on first read through about when the
SVGAnimatedString qualifier really was needed but in total I think this is an
improvement.

lgtm.

[pdr., 2016-02-16 23:02:10]

On 2016/02/15 at 16:17:27, davve wrote:
> I like it. I was admittedly a bit confused on first read through about when
the SVGAnimatedString qualifier really was needed but in total I think this is
an improvement.
> 
> lgtm.

LGTM 2

[fs, 2016-02-17 11:26:36]

The CQ bit was checked by fs@opera.com

[commit-bot: I haz the power, 2016-02-17 11:27:00]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1697593002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1697593002/20001

[commit-bot: I haz the power, 2016-02-17 12:31:05]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-02-17 12:32:10]

Description was changed from

==========
Simplify SVGAnimatedHref

Let SVGAnimatedHref hold the actual value for 'href' and just wrap the
object for 'xlink:href'. This means we can get rid of most of the
overrides.

BUG=584142
==========

to

==========
Simplify SVGAnimatedHref

Let SVGAnimatedHref hold the actual value for 'href' and just wrap the
object for 'xlink:href'. This means we can get rid of most of the
overrides.

BUG=584142

Committed: https://crrev.com/31faa6d4fc1e3396c3749b4b8986c7a86bab2240
Cr-Commit-Position: refs/heads/master@{#375861}
==========

[commit-bot: I haz the power, 2016-02-17 12:32:11]

Patchset 2 (id:??) landed as
https://crrev.com/31faa6d4fc1e3396c3749b4b8986c7a86bab2240
Cr-Commit-Position: refs/heads/master@{#375861}