PlzNavigate: clear pending entry on aborted navigations

PlzNavigate: clear pending entry on aborted navigations

This CL makes it so that PlzNavigate will also clear the pending
NavigationEntry on aborted navigations.

BUG=475027
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_site_isolation

Committed: https://crrev.com/d424431fe0e938d3840d7dd18203da3a6eeeed9c
Cr-Commit-Position: refs/heads/master@{#380976}

[clamy, 2016-02-12 16:05:17]

Description was changed from

==========
PlzNavigate: clear pending entry on aborted navigations

This CL makes it so that PlzNavigate will also celar the pending
NavigationEntry on aborted navigations.

BUG=475027
==========

to

==========
PlzNavigate: clear pending entry on aborted navigations

This CL makes it so that PlzNavigate will also celar the pending
NavigationEntry on aborted navigations.

BUG=475027
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_site_isolation
==========

[clamy, 2016-02-12 17:31:42]

Description was changed from

==========
PlzNavigate: clear pending entry on aborted navigations

This CL makes it so that PlzNavigate will also celar the pending
NavigationEntry on aborted navigations.

BUG=475027
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_site_isolation
==========

to

==========
PlzNavigate: clear pending entry on aborted navigations

This CL makes it so that PlzNavigate will also celar the pending
NavigationEntry on aborted navigations.

BUG=475027
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_site_isolation
==========

[clamy, 2016-02-12 17:31:42]

clamy@chromium.org changed reviewers:
+ creis@chromium.org, csharrison@chromium.org

[clamy, 2016-02-12 17:32:15]

@creis, csharrison: PTAL
@csharrison: if it collides with your patch too much it can wait.

[Charlie Harrison, 2016-02-12 17:47:34]

On 2016/02/12 17:32:15, clamy wrote:
> @creis, csharrison: PTAL
> @csharrison: if it collides with your patch too much it can wait.

This should be easy to merge regardless of which patch lands first, so I don't
mind.

[Charlie Reis, 2016-02-17 05:23:26]

Sure, sharing this code with PlzNavigate makes sense.

I'd prefer to land https://codereview.chromium.org/1661423002/ first if
possible, though-- we're close to getting that one in.  (This CL appears to be
modifying the code as well as moving it, so I don't want to risk any merge
conflicts as we change it in the other CL.)

[clamy, 2016-02-17 13:31:52]

Ok, though for the current architecture, the CL is just extracting the code in a
helper function and normally not modifying it.

[Charlie Reis, 2016-02-17 22:51:21]

On 2016/02/17 13:31:52, clamy wrote:
> Ok, though for the current architecture, the CL is just extracting the code in
a
> helper function and normally not modifying it.

Ah-- I was referring to inverting the conditional and making it an early return.
 It does behave the same, but it's another opportunity for a merge conflict
introducing a bug, which is why I suggested to wait.

[clamy, 2016-03-02 14:23:10]

Description was changed from

==========
PlzNavigate: clear pending entry on aborted navigations

This CL makes it so that PlzNavigate will also celar the pending
NavigationEntry on aborted navigations.

BUG=475027
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_site_isolation
==========

to

==========
PlzNavigate: clear pending entry on aborted navigations

This CL makes it so that PlzNavigate will also clear the pending
NavigationEntry on aborted navigations.

BUG=475027
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_site_isolation
==========

[clamy, 2016-03-02 14:25:07]

clamy@chromium.org changed reviewers:
+ nasko@chromium.org

[clamy, 2016-03-02 14:25:52]

@nasko: this was waiting for issue 1661423002 to land, but Charlie is ooo
currently. Could PTAL instead?

[nasko, 2016-03-03 21:34:53]

LGTM

[clamy, 2016-03-14 13:33:25]

The CQ bit was checked by clamy@chromium.org

[clamy, 2016-03-14 13:33:26]

The patchset sent to the CQ was uploaded after l-g-t-m from nasko@chromium.org
Link to the patchset: https://codereview.chromium.org/1697563002/#ps40001
(title: "Rebase")

[commit-bot: I haz the power, 2016-03-14 13:33:40]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1697563002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1697563002/40001

[commit-bot: I haz the power, 2016-03-14 14:58:21]

Description was changed from

==========
PlzNavigate: clear pending entry on aborted navigations

This CL makes it so that PlzNavigate will also clear the pending
NavigationEntry on aborted navigations.

BUG=475027
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_site_isolation
==========

to

==========
PlzNavigate: clear pending entry on aborted navigations

This CL makes it so that PlzNavigate will also clear the pending
NavigationEntry on aborted navigations.

BUG=475027
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_site_isolation
==========

[commit-bot: I haz the power, 2016-03-14 14:58:22]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-03-14 14:59:16]

Description was changed from

==========
PlzNavigate: clear pending entry on aborted navigations

This CL makes it so that PlzNavigate will also clear the pending
NavigationEntry on aborted navigations.

BUG=475027
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_site_isolation
==========

to

==========
PlzNavigate: clear pending entry on aborted navigations

This CL makes it so that PlzNavigate will also clear the pending
NavigationEntry on aborted navigations.

BUG=475027
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_site_isolation

Committed: https://crrev.com/d424431fe0e938d3840d7dd18203da3a6eeeed9c
Cr-Commit-Position: refs/heads/master@{#380976}
==========

[commit-bot: I haz the power, 2016-03-14 14:59:17]

Patchset 3 (id:??) landed as
https://crrev.com/d424431fe0e938d3840d7dd18203da3a6eeeed9c
Cr-Commit-Position: refs/heads/master@{#380976}