third_party/WebKit/Source/core/layout/svg/LayoutSVGRoot.cpp - Issue 1697543002: Check IsFixed specifically instead of presence of other flags.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/layout/svg/LayoutSVGRoot.cpp

Issue 1697543002: Check IsFixed specifically instead of presence of other flags. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Remove potentially wrong IsFixed argument Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/LayoutTests/fast/svg/no-fixed-in-svg-assert-expected.txt ('k') | third_party/WebKit/Source/core/paint/PaintLayer.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/layout/svg/LayoutSVGRoot.cpp

diff --git a/third_party/WebKit/Source/core/layout/svg/LayoutSVGRoot.cpp b/third_party/WebKit/Source/core/layout/svg/LayoutSVGRoot.cpp

index 165d5f50d4b7783a9ae406a29deb71a29b05700c..8346501fc57bfef0d95c18bfdf6c05efd1b6cc19 100644

--- a/third_party/WebKit/Source/core/layout/svg/LayoutSVGRoot.cpp

+++ b/third_party/WebKit/Source/core/layout/svg/LayoutSVGRoot.cpp

@@ -348,7 +348,7 @@ void LayoutSVGRoot::mapToVisibleRectInAncestorSpace(const LayoutBoxModelObject*

// to convert from SVG viewport coordinates to local CSS box coordinates.

void LayoutSVGRoot::mapLocalToAncestor(const LayoutBoxModelObject* ancestor, TransformState& transformState, MapCoordinatesFlags mode, bool* wasFixed, const PaintInvalidationState* paintInvalidationState) const

{

- ASSERT(mode & ~IsFixed); // We should have no fixed content in the SVG layout tree.

+ ASSERT(!(mode & IsFixed)); // We should have no fixed content in the SVG layout tree.

LayoutReplaced::mapLocalToAncestor(ancestor, transformState, mode | ApplyContainerFlip, wasFixed, paintInvalidationState);

}