Check IsFixed specifically instead of presence of other flags.

Check IsFixed specifically instead of presence of other flags.

LayoutSVGRoot::mapLocalToAncestor has an assert to check that there is
no fixed content in the SVG layout tree. However, it did incorrectly
rely on MapCoordinatesFlags being non-0. Changed the assert to check
for the Fixed flag explicitly instead.

R=mstensho@opera.com
BUG=586478
Committed: https://crrev.com/3fee2c883a079398c3201fa1262916b2a4d4a9c0
Cr-Commit-Position: refs/heads/master@{#375458}

[rune, 2016-02-12 12:57:22]

The CQ bit was checked by rune@opera.com to run a CQ dry run

[commit-bot: I haz the power, 2016-02-12 12:57:51]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1697543002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1697543002/1

[rune, 2016-02-12 12:57:55]

ptal

[mstensho (USE GERRIT), 2016-02-12 12:59:05]

lgtm

[commit-bot: I haz the power, 2016-02-12 13:55:00]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-02-12 13:55:01]

Dry run: Try jobs failed on following builders:
  linux_chromium_chromeos_rel_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[rune, 2016-02-12 14:00:54]

The CQ bit was checked by rune@opera.com

[commit-bot: I haz the power, 2016-02-12 14:03:16]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1697543002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1697543002/1

[commit-bot: I haz the power, 2016-02-12 14:38:29]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-02-12 14:38:30]

Try jobs failed on following builders:
  mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[rune, 2016-02-12 14:42:08]

rune@opera.com changed reviewers:
+ fs@opera.com, schenney@chromium.org

[rune, 2016-02-12 14:42:08]

Adding fs@ and schenney@. Do you make any sense of this?

The failing test is svg/custom/svg-fixed-position.svg

[fs, 2016-02-12 15:07:15]

On 2016/02/12 at 14:42:08, rune wrote:
> Adding fs@ and schenney@. Do you make any sense of this?
> 
> The failing test is svg/custom/svg-fixed-position.svg

This assert is obviously both confusing and confused though. I wonder if it
would be better suited in the callers (i.e. when propagating from any non-root
SVG layout objects). I guess the case where your test triggers this when doing
something directly on the box of the SVG root? That'd be the case for the
failing test at least. Judging from the comment it wasn't factoring that in.

[fs, 2016-02-12 15:10:33]

On 2016/02/12 at 15:07:15, fs wrote:
> On 2016/02/12 at 14:42:08, rune wrote:
> > Adding fs@ and schenney@. Do you make any sense of this?
> > 
> > The failing test is svg/custom/svg-fixed-position.svg
> 
> This assert is obviously both confusing and confused though. I wonder if it
would be better suited in the callers (i.e. when propagating from any non-root
SVG layout objects). I guess the case where your test triggers this when doing
something directly on the box of the SVG root? That'd be the case for the
failing test at least. Judging from the comment it wasn't factoring that in.

(Also, your transformation is a bit weird: Before: a & ~1 => (a & 0xe) != 0;
after: !(a & 1) => (a & 1) != 0 - but the problem still likely boils down to not
expecting UseTransforms to not be set here.)

[rune, 2016-02-15 10:53:06]

The CQ bit was checked by rune@opera.com to run a CQ dry run

[commit-bot: I haz the power, 2016-02-15 10:53:21]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1697543002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1697543002/20001

[commit-bot: I haz the power, 2016-02-15 12:40:13]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-02-15 12:40:16]

Dry run: This issue passed the CQ dry run.

[rune, 2016-02-15 14:08:42]

Care to take a look at the new PS, fs@ or mstensho@ ?

[mstensho (USE GERRIT), 2016-02-15 14:10:45]

lgtm V2.0

[fs, 2016-02-15 14:13:06]

lgtm

[rune, 2016-02-15 14:18:01]

The CQ bit was checked by rune@opera.com

[commit-bot: I haz the power, 2016-02-15 14:18:21]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1697543002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1697543002/20001

[commit-bot: I haz the power, 2016-02-15 14:23:01]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-02-16 22:50:02]

Description was changed from

==========
Check IsFixed specifically instead of presence of other flags.

LayoutSVGRoot::mapLocalToAncestor has an assert to check that there is
no fixed content in the SVG layout tree. However, it did incorrectly
rely on MapCoordinatesFlags being non-0. Changed the assert to check
for the Fixed flag explicitly instead.

R=mstensho@opera.com
BUG=586478
==========

to

==========
Check IsFixed specifically instead of presence of other flags.

LayoutSVGRoot::mapLocalToAncestor has an assert to check that there is
no fixed content in the SVG layout tree. However, it did incorrectly
rely on MapCoordinatesFlags being non-0. Changed the assert to check
for the Fixed flag explicitly instead.

R=mstensho@opera.com
BUG=586478

Committed: https://crrev.com/3fee2c883a079398c3201fa1262916b2a4d4a9c0
Cr-Commit-Position: refs/heads/master@{#375458}
==========

[commit-bot: I haz the power, 2016-02-16 22:50:03]

Patchset 2 (id:??) landed as
https://crrev.com/3fee2c883a079398c3201fa1262916b2a4d4a9c0
Cr-Commit-Position: refs/heads/master@{#375458}